Skip to content

we can't have profiles because we are also in the rustc worksapce#637

Merged
RalfJung merged 1 commit into
rust-lang:masterfrom
RalfJung:profile
Feb 17, 2019
Merged

we can't have profiles because we are also in the rustc worksapce#637
RalfJung merged 1 commit into
rust-lang:masterfrom
RalfJung:profile

Conversation

@RalfJung

Copy link
Copy Markdown
Member

Otherwise we get

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /home/r/src/rust/rustc.3/src/tools/miri/Cargo.toml
workspace: /home/r/src/rust/rustc.3/Cargo.toml

@RalfJung

Copy link
Copy Markdown
Member Author

Argh, what's with Travis' mac builder?

@RalfJung

Copy link
Copy Markdown
Member Author

Wait, what? Since when is this repo in the rust-lang org? Is that connected with our mac builders being screwed up?

@oli-obk

oli-obk commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

Since yesterday evening. Yea, ci is still messed up, but it's being worked on

@RalfJung

Copy link
Copy Markdown
Member Author

Well, this blocks rust-lang/rust#58535

@emilyalbini

Copy link
Copy Markdown
Member

Can you force push this branch to get the build started on travis-ci.com @RalfJung? Thanks!

@RalfJung

Copy link
Copy Markdown
Member Author

Cycling the PR should usually do it.

@RalfJung RalfJung closed this Feb 17, 2019
@RalfJung RalfJung reopened this Feb 17, 2019
@RalfJung

RalfJung commented Feb 17, 2019

Copy link
Copy Markdown
Member Author

Hm, it started a new build that works but the old build is still around and blocks merging?

Could it be that the repo settings need to be adjusted to "require" the right thing to pass? Is there a way @oli-obk and/or me could get enough powers in this repo to configure such things?

@emilyalbini

Copy link
Copy Markdown
Member

Hm, it started a new build that works but the old build is still around and blocks merging?

Yeah, the issue is that the GitHub UI allows you to block on a check only when it successfully completed, so I was waiting for it to finish before switching the block.

Reconfigured it to block on both AppVeyor and the new Travis.

Is there a way @oli-obk and/or me could get enough powers in this repo to configure such things?

Yeah, I can give them to both of you, but do you change those settings often? We'd prefer to avoid giving admin perms when not necessary, but it's fine if you need them.

@RalfJung

Copy link
Copy Markdown
Member Author

Yeah, I can give them to both of you, but do you change those settings often?

Not really. We'll likely ask you to set up bors some time soon-ish and that's it.

So, yeah, not having admin powers is also fine.

@RalfJung
RalfJung merged commit 76138c5 into rust-lang:master Feb 17, 2019
@RalfJung
RalfJung deleted the profile branch March 26, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants