Skip to content

Removed transmute from intrinsic.rs#448

Merged
RalfJung merged 2 commits into
rust-lang:masterfrom
TheDarkula:master
Sep 1, 2018
Merged

Removed transmute from intrinsic.rs#448
RalfJung merged 2 commits into
rust-lang:masterfrom
TheDarkula:master

Conversation

@TheDarkula

Copy link
Copy Markdown

@RalfJung

Copy link
Copy Markdown
Member

That looks exactly right, thanks! However, it seems you worked on an older version of master; GitHub says there are merge conflicts. (And nothing has landed in the last 1h so these conflicts were present already when you opened the PR.)

Can you resolve those conflicts?

@RalfJung

Copy link
Copy Markdown
Member

Thanks!

Now we just have to wait for a nightly to happen.

@TheDarkula

Copy link
Copy Markdown
Author

Ah. I was wondering why the builds were still failing :)

@RalfJung

Copy link
Copy Markdown
Member

Now that we got a nightly, please update the rust-toolchain file to nightly-2018-08-32. Then CI should become green.

@RalfJung

RalfJung commented Sep 1, 2018

Copy link
Copy Markdown
Member

Eh, sorry, I had a typo there. There was no nightly on August 32snd.^^

Let me land the other PR first to make CI green again...

@RalfJung

RalfJung commented Sep 1, 2018

Copy link
Copy Markdown
Member

I resolved that conflict for you. Once CI is green, we can land this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants