refactor: deprecate RAND_MAX constant in FreeBSD#5119
Open
dybucc wants to merge 2 commits into
Open
Conversation
dybucc
force-pushed
the
rand-max-deprecation
branch
from
35d04d3 to
4346f10
Compare
This comment has been minimized.
This comment has been minimized.
dybucc
force-pushed
the
rand-max-deprecation
branch
2 times, most recently
from
ddee909 to
c0316ee
Compare
This comment has been minimized.
This comment has been minimized.
dybucc
added a commit
to dybucc/libc
that referenced
this pull request
Jun 8, 2026
This is a follow up to rust-lang#5119. In this instance, the deprecated symbol has been removed to target the 1.0 release, and the SemVer-tracking plain text files have been updated.
3 tasks
dybucc
added a commit
to dybucc/libc
that referenced
this pull request
Jun 8, 2026
This is a follow up to rust-lang#5119. In this instance, the deprecated symbol has been removed to target the 1.0 release, and the SemVer-tracking plain text files have been updated.
dybucc
added a commit
to dybucc/libc
that referenced
this pull request
Jun 9, 2026
This is a follow up to rust-lang#5119. In this instance, the deprecated symbol has been removed to target the 1.0 release, and the SemVer-tracking plain text files have been updated.
dybucc
force-pushed
the
rand-max-deprecation
branch
from
c0316ee to
10b10e8
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
CI actually passes. There seems to be an issue with a glob import that is not used, but this has not |
rustbot
added
the
stable-nominated
dybucc
added a commit
to dybucc/libc
that referenced
this pull request
Jun 15, 2026
This is a follow up to rust-lang#5119. In this instance, the deprecated symbol has been removed to target the 1.0 release, and the SemVer-tracking plain text files have been updated.
dybucc
force-pushed
the
rand-max-deprecation
branch
from
10b10e8 to
3b4385c
Compare
This comment has been minimized.
This comment has been minimized.
This patch adds a new macro that can be used for declaring constants when these are known to possibly change upstream across target OS/ABI versions.
This symbol has been modified in the last few versions of FreeBSD. It can possibly be assumed that the constant is likely to change upstream, and users should likely be advised of its use. The link in the doc comment is broken until rust-lang#5179 gets merged.
3 tasks
dybucc
force-pushed
the
rand-max-deprecation
branch
from
3b4385c to
86e3d3b
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This constant does not seem to have had any changes since a binding was defined in all modules but the FreeBSD tree.
This deprecation may or may not be worth it, as the only real change was between FreeBSD 12 and FreeBSD 13.
This type of constant seems like the "delimitter" value mentioned in #3131, so that's why I thought it could be marked for deprecation.
Sources
FreeBSD tree in
libcwhere the constant was added to specific FreeBSD releases as it changed between FreeBSD 12 and FreeBSD 13.C standard library documentation (unofficial) mentioning the purpose of the constant as a "limit" value
rand.Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI@rustbot label +stable-nominated