Skip to content

CI: Consolidate and blanket-ignore kernel definitions on non-glibc#2113

Merged
bors merged 2 commits into
rust-lang:masterfrom
joshtriplett:ci-kernel
Mar 16, 2021
Merged

CI: Consolidate and blanket-ignore kernel definitions on non-glibc#2113
bors merged 2 commits into
rust-lang:masterfrom
joshtriplett:ci-kernel

Conversation

@joshtriplett

Copy link
Copy Markdown
Member

Skip definitions from the kernel on non-glibc Linux targets.
They're libc-independent, so we only need to check them on one
libc. We don't want to break CI if musl or another libc doesn't
have the definitions yet. (We do still want to check them on
every glibc target, though, as some of them can vary by
architecture.)

@rust-highfive

Copy link
Copy Markdown

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@joshtriplett

Copy link
Copy Markdown
Member Author

This also experimentally removes P_PIDFD from the ignores on glibc. Let's see if that builds now; if not, I can re-add it.

@JohnTitor

Copy link
Copy Markdown
Member

FYI: https://www.githubstatus.com/incidents/s654n76c1bwr
Let's wait until it's resolved.

@JohnTitor

Copy link
Copy Markdown
Member

Looks reasonable to me.

This also experimentally removes P_PIDFD from the ignores on glibc. Let's see if that builds now; if not, I can re-add it.

Let's check it, @bors r+

@bors

bors commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

📌 Commit db07dbc has been approved by JohnTitor

@bors

bors commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit db07dbc with merge ce7783a...

bors added a commit that referenced this pull request Mar 15, 2021
CI: Consolidate and blanket-ignore kernel definitions on non-glibc

Skip definitions from the kernel on non-glibc Linux targets.
They're libc-independent, so we only need to check them on one
libc. We don't want to break CI if musl or another libc doesn't
have the definitions yet. (We do still want to check them on
every glibc target, though, as some of them can vary by
architecture.)
@bors

bors commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-actions

@JohnTitor

Copy link
Copy Markdown
Member

Actually, failed on mips-unknown-linux-gnu.

Skip definitions from the kernel on non-glibc Linux targets.
They're libc-independent, so we only need to check them on one
libc. We don't want to break CI if musl or another libc doesn't
have the definitions yet. (We do still want to check them on
every glibc target, though, as some of them can vary by
architecture.)
@joshtriplett

Copy link
Copy Markdown
Member Author

Fixed.

@bors r=JohnTitor

@bors

bors commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

📌 Commit 0a9aec7 has been approved by JohnTitor

@bors

bors commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit 0a9aec7 with merge 56c8549...

@bors

bors commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 56c8549 to master...

@bors bors merged commit 56c8549 into rust-lang:master Mar 16, 2021
@joshtriplett joshtriplett deleted the ci-kernel branch March 16, 2021 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants