Fake ToOwned trait#733
Open
clarfonthey wants to merge 1 commit into
Open
Conversation
|
For posterity: see this Zulip thread |
Member
|
This seems mostly fine to me, but I would like to see the full story for not depending on alloc to be resolved before merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows one of the suggestions for removing the
allocdependency, specifically to allow movingHashMapintoalloc: essentially, if we don't haveToOwned, store-bought is fine.The expectation here is that specifically for libstd, they can implement a blanket forwarding of the actual
ToOwnedto this trait and it should work as expected. This is fine by coherence rules even though the coherence rules kind of don't make any more sense once you are libstd.Not 100% sure if this should be merged immediately, since I want to make sure that we actually can get a full alloc-less version of hashbrown working first. But the implementation seems relatively straightforward.