Support GitHub Actions Badges#1838
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
CryZe
force-pushed
the
github-badge
branch
2 times, most recently
from
d127987 to
4fe7d4f
Compare
|
Can we call the badge |
sgrif
left a comment
sgrif
left a comment
There was a problem hiding this comment.
Other than the badge name this looks fine
|
Alright, I made those changes :) |
CryZe
force-pushed
the
github-badge
branch
3 times, most recently
from
1d0c8c1 to
d85627c
Compare
|
Travis is having issues it seems. |
|
This is done from my side. |
carols10cents
left a comment
carols10cents
left a comment
There was a problem hiding this comment.
In the github actions documentation, it says:
If your workflow uses the name keyword, you can reference the workflow by name. If the name of your workflow contains white space, you'll need to replace the space with the URL encoded string %20. For more information about the name keyword, see "Workflow syntax for GitHub Actions."
I think we should be doing the replacement of any spaces in the workspace key to %20, so that it'll work either way people specify it and folks won't need to publish a new version if they have spaces in their workspace name and don't do the substitution manually.
Also could you open a PR in the cargo repo documenting this badge in here? https://github.com/rust-lang/cargo/blob/master/src/doc/src/reference/manifest.md#package-metadata I'll merge this PR before the docs are merged, but I'd like to know the docs are on their way and I'd like to try manually testing out this new badge by following the docs.
Thanks!!
|
Isn't this true for all URLs in general? Shouldn't crates.io properly percentage encode all the badge URL values anyway? I'm not sure how this is different here. Anyways, I think I might need some help how and where I would do this. I don't really know the crates.io codebase, so I might need some mentoring. (Or should I really just do a I'll open a PR in the cargo repo. |
|
Here's an example - for the appveyor badges, we have to replace underscores or periods with hyphens. |
This is implemented here: rust-lang/crates.io#1838
|
Alright, I implemented the whitespace escaping. |
| classNames: ['badge'], | ||
| repository: alias('badge.attributes.repository'), | ||
| workflow: computed('badge.attributes.workflow', function() { | ||
| return this.get('badge.attributes.workflow').replace(' ', '%20'); |
There was a problem hiding this comment.
This will only replace the first space – it’d have to be / /g. But I agree that this is strange and something like encodeURIComponent() would seem to make more sense.
|
@rustbot modify labels to +s-waiting-on-review and -s-waiting-on-author |
|
@rustbot modify labels: -S-waiting-on-author |
|
@carols10cents friendly ping? Would be really nice to have this. |
... and don't replace them with anything because crates.io does not support GitHub Actions yet. But it's almost there: rust-lang/crates.io#1838 Thanks @atouchet for noticing this.
|
Don't want to be rude, but is there a chance this is going to be merged anytime soon? |
cargo badges does not support github actions yet: rust-lang/crates.io#1838
cargo badges does not support github actions yet: rust-lang/crates.io#1838
|
Whether you're trying to be rude or not, you are being rude. I'm not getting paid to work on crates.io right now, so I'm prioritizing paid work. Also, there's a global pandemic going on. So you all need to chill. |
|
@carols10cents I don't think a person asking the status of things after roughly a month of no action is rude. We fully realize that neither you nor anyone else gets paid to work on crates.io. All we were seeking was a status update, whether from you or someone else. A simple statement that you (and others) are preoccupied with staying healthy (hopefully!) and your paid job would have sufficed. It's something we all understand, to say the least. Somewhat related, I'm home myself and am more than willing to help out. If there are updates to code that need to be done, I can (likely) do that. I can also review if desired. |
All status changes are made to the issue. If there is no update here, there has been no change in status. I do think it's rude. |
|
Next time I get a chance to review PRs, I'll be reviewing them in "Least Recently Updated" order. My current queue: https://github.com/rust-lang/crates.io/pulls?q=is%3Aopen+is%3Apr+assignee%3Acarols10cents+sort%3Aupdated-asc |
|
@carols10cents I've been thinking about your comments a lot since yesterday. Of course you decide how to use your unpaid time. That said, in my experience across many open source projects, asking for a status update or pinging a non-responsive maintainer (and I've been on that side plenty of times myself) is often considered fine -- sometimes issues get lost in the noise, and it's useful to highlight those that need action. Being explicit about a lack of time (whether paid or not) is useful and would likely have led to fewer comments about this, and could maybe also elicit discussion about whether or not another maintainer could take over your review. However, I feel dismayed about your last comment. In saying that you'll review PRs in LRU order, I worry that you use your very scarce time for things that are arguably of lesser priority for crates.io users, which I feel would be unfortunate. |
|
Just a visitor here (actually a subscriber who doesn't know how I landed on this issue), but I would recommend let's not discuss this things here. Thanks |
|
Moderation note: @carols10cents has made it clear that asking for further status updates is unwanted. Similarly, engaging into a meta discussion about this is also not productive. Please respect the maintainer's wishes and stop. |
- I would like to add a badge to the Cargo manifest too, but it's currently WIP: rust-lang/crates.io#1838
- I would like to add a badge to the Cargo manifest too, but it's currently WIP: rust-lang/crates.io#1838
|
I'm going to close this PR since we decided to deprecate the badges feature in the team meeting yesterday. See #2436 and related issues for more detail. Thanks for taking your time! |
cargo badges does not support github actions yet: rust-lang/crates.io#1838
16 participants
Documented here https://help.github.com/en/articles/configuring-a-workflow#adding-a-workflow-status-badge-to-your-repository