Proposal
Remove the run-pass-valgrind test suite. This test suite is not properly hooked up to bootstrap, and run-pass-valgrind tests don't actually get exercised under valgrind. See https://github.com/rust-lang/rust/blob/1b3b8e7b0265162853c650ead09905bc3cdaeae9/src/tools/compiletest/src/runtest/valgrind.rs#L7-L12. Providing valgrind paths was not hooked up to bootstrap and our CI jobs don't run it. opt-dist currently run the run-pass-valgrind tests but because it's not properly hooked up in bootstrap, they are just naive run-pass tests.
Mentors or Reviewers
Bootstrap reviewers (@Kobzol who is already reviewing the rust-lang/rust#131351 PR).
Process
The main points of the Major Change Process are as follows:
You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
Proposal
Remove the
run-pass-valgrindtest suite. This test suite is not properly hooked up to bootstrap, andrun-pass-valgrindtests don't actually get exercised under valgrind. See https://github.com/rust-lang/rust/blob/1b3b8e7b0265162853c650ead09905bc3cdaeae9/src/tools/compiletest/src/runtest/valgrind.rs#L7-L12. Providing valgrind paths was not hooked up to bootstrap and our CI jobs don't run it.opt-distcurrently run therun-pass-valgrindtests but because it's not properly hooked up in bootstrap, they are just naiverun-passtests.Mentors or Reviewers
Bootstrap reviewers (@Kobzol who is already reviewing the rust-lang/rust#131351 PR).
Process
The main points of the Major Change Process are as follows:
@rustbot second.-C flag, then full team check-off is required.@rfcbot fcp mergeon either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.