feat(cli): Support cargo Cargo.toml#12281
Merged
Merged
Conversation
This wasn't in the original Pre-RFC but in terms of consistently accepting manifests everything, I think this makes sense.
Collaborator
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-cli
39 tasks
epage
force-pushed
the
toml
branch
4 times, most recently
from
June 19, 2023 15:47
f11ebdd to
7f2eca4
Compare
weihanglo
reviewed
Jun 21, 2023
weihanglo
approved these changes
Jun 21, 2023
Member
There was a problem hiding this comment.
Let's leave teaching discussion then.
I love the consistency between this and #12289. Merge and move on.
Edited: Just want to note that this cargo Cargo.toml can be seen as a shorthand of cargo run --manifest-path Cargo.toml.
Member
|
@bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 22, 2023
Update cargo 2 commits in dead4b8740c4b6a8ed5211e37c99cf81d01c3b1c..4cebd130ebca3bc219180a54f3e26cc1b14a91de 2023-06-20 20:07:17 +0000 to 2023-06-21 18:59:29 +0000 - fix: Allow embedded manifests in all commands (rust-lang/cargo#12289) - feat(cli): Support `cargo Cargo.toml` (rust-lang/cargo#12281) r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is making the assumption that we want full unity between places accepting both single-file packages and
Cargo.tomlfor #12207. This has not been brought up before in any of the discussions (Internals, eRFC), so I can understand if there are concerns about this and we decide to hold off.We might want to resolve symlinks before this so people can have a prettier name for these.
How should we test and review this PR?
The test for this was added in a commit before the actual change, letting people see how the behavior changed.