This repository was archived by the owner on Nov 28, 2023. It is now read-only.
Update link.x#61
Merged
Merged
Conversation
Member
|
@richardeoin, looks good, thank you! Could you add a corresponding change log entry? @almindor I think it's better to bump the version together with the release-relevant changelog modifications, so I'd rather do this in a separate PR. Also we need yet another fix for this: rust-lang/rust#73564 (comment) |
Similar to rust-embedded#38, riscv compilers may also generate 'small ro data' `.srodata` sections. This doesn't appear to be well documented, but see [this blog post](https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-toolchain) for small amount of context.
Contributor
Author
|
Done! Thanks for the eh_frame fix too, I hit that on recent nightlies |
Member
|
bors r=almindor |
Contributor
|
Build succeeded: |
Member
|
Released in v0.7.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #38, riscv compilers may also generate 'small ro data'
.srodatasections.This doesn't appear to be well documented, but see this blog post for small amount of context.