test: add changelog and integer-ID coverage for Client::deleteIds - #2318
Draft
ruflin wants to merge 3 commits into
Draft
test: add changelog and integer-ID coverage for Client::deleteIds#2318ruflin wants to merge 3 commits into
ruflin wants to merge 3 commits into
Conversation
Co-authored-by: Nicolas Ruflin <ruflin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same changelog + integer-ID test as now pushed to AntoineRoue’s
9.xbranch on #2317.A PR opened against that fork branch was not possible (GitHub App cannot create pull requests on
AntoineRoue/Elastica). Instead the two follow-up commits were pushed to #2317 via maintainer edits.This PR remains a same-repo fallback targeting
9.x. It can be closed if #2317 is merged with those commits.Changes
Client::deleteIds().CHANGELOG.md.testDeleteIdsWithIntegerIds()intests/ClientFunctionalTest.php.Fixes #2316