chore(ci): bump codecov-action from v2 to v5 - #2307
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe CI workflow upgrades the Codecov GitHub Action from v2 to v5, configures coverage files, token handling, failure tolerance, and conditional OIDC support, and documents these changes in the changelog. ChangesCodecov CI integration
Estimated code review effort: 2 (Simple) | ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow to use the current Codecov GitHub Action major version and adapts configuration to the v5 input contract to keep coverage uploads working reliably.
Changes:
- Bumped
codecov/codecov-actionfromv2tov5in the CI workflow. - Added v5-specific inputs (
token,fail_ci_if_error: false) and a conditionaluse_oidcsetting to avoid fork PR OIDC issues. - Documented the change in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
CHANGELOG.md |
Notes the Codecov action bump and related input changes under Unreleased. |
.github/workflows/continuous-integration.yaml |
Switches to codecov/codecov-action@v5 and updates inputs, including conditional OIDC behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: 'Upload coverage to Codecov' | ||
| uses: codecov/codecov-action@v2 | ||
| uses: codecov/codecov-action@v5 |
There was a problem hiding this comment.
uses: entries in this workflow are consistently quoted (e.g., 'actions/checkout@v4', 'shivammathur/setup-php@v2'). For consistency (and to avoid YAML edge cases with @), quote codecov/codecov-action@v5 as well.
| uses: codecov/codecov-action@v5 | |
| uses: 'codecov/codecov-action@v5' |
| * Added support for "search after" based pagination [#1645](https://github.com/ruflin/Elastica/issues/1645) | ||
| * Added support for the `seq_no_primary_term` search option and the `if_seq_no` / `if_primary_term` index options to enable optimistic concurrency control [#2284](https://github.com/ruflin/Elastica/pull/2284) | ||
| ### Changed | ||
| * Bumped `codecov/codecov-action` from `v2` to `v5` and aligned it with the v5 input contract (`token`, `fail_ci_if_error: false`, conditional `use_oidc`). |
There was a problem hiding this comment.
This changelog’s bullet entries in the surrounding section don’t end with periods; this new entry does. Consider removing the trailing period for consistency.
| * Bumped `codecov/codecov-action` from `v2` to `v5` and aligned it with the v5 input contract (`token`, `fail_ci_if_error: false`, conditional `use_oidc`). | |
| * Bumped `codecov/codecov-action` from `v2` to `v5` and aligned it with the v5 input contract (`token`, `fail_ci_if_error: false`, conditional `use_oidc`) |
`codecov/codecov-action@v2` is several majors behind the current v5.5.x line. Bump to v5 and align with the new input contract: - Pass `token` from the `CODECOV_TOKEN` secret. - Set `fail_ci_if_error: false` so a flaky upload does not block the build. - Conditionally enable `use_oidc` to work around the v5.4.1 regression that breaks OIDC token requests on fork pull requests.
The conditional use_oidc input made the action request an OIDC token, but id-token is never part of the default GITHUB_TOKEN scope, so the exchange failed with 'Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable' and took the whole PHPUnit job down with it (fail_ci_if_error does not cover an unhandled error inside the action). Request id-token: write explicitly, plus contents: read since naming a job-level permissions block drops the rest.
885f12e to
459c986
Compare
Summary
codecov/codecov-action@v2is several majors behind the current v5.5.xline. Bump to v5 and align with the new input contract:
tokenfrom theCODECOV_TOKENsecret (still works for thetokenless fallback if no secret is configured).
fail_ci_if_error: falseso a flaky upload does not block thebuild.
use_oidcto work around thev5.4.1 regression
that breaks OIDC token requests on fork pull requests.
Identified during a P0/P1 code-review pass.
Test plan
Summary by CodeRabbit