Skip to content

Fix test fail caused by bundler-1.13.x#161

Merged
hsbt merged 8 commits into
masterfrom
fix-latest-bundler
Sep 16, 2016
Merged

Fix test fail caused by bundler-1.13.x#161
hsbt merged 8 commits into
masterfrom
fix-latest-bundler

Conversation

@hsbt

@hsbt hsbt commented Sep 10, 2016

Copy link
Copy Markdown
Member

bundler-1.13.0 references Gem::Source. It is only provided from rubygems-2.6.x

@drbrain

drbrain commented Sep 10, 2016

Copy link
Copy Markdown
Member

Hrm, Gem::Source should exist for all of RubyGems 2.x

@hsbt

hsbt commented Sep 11, 2016

Copy link
Copy Markdown
Member Author

rubygems/bundler#4944

It is caused by implicitly loading of Gem::Source, so rubygems 2.5 and 2.4 did not load it probably.

@hsbt

hsbt commented Sep 11, 2016

Copy link
Copy Markdown
Member Author

And I noticed travis boxes defects that no effects with rubygems and bundler downgrading to @BanzaiMan

@aycabta

aycabta commented Sep 11, 2016

Copy link
Copy Markdown
Member

I researched about this.

rubygems/bundler#4944 is merged at rubygems/bundler@3b5d047, this merge commit hasn't been in 1.13. The error what says NameError: uninitialized constant Gem::Source will fixed by this commit with new release.

But, there is another problem in Bundler's HEAD. Gem::Specification#full_gem_path in bundler/rubygems_ext.rb uses Bundler::Plugin::API::Source. The namespace is defined by cascading autoload:

Finally, NameError: uninitialized constant Bundler::Plugin::API::Source is occurred. The require in Bundler::Plugin::API::Source is added at rubygems/bundler@b94002b, this commit haven't been released. So we haven't known this error.

I don't have a detailed knowledge about Rake and Bundler, tentatively I just report.

@aycabta

aycabta commented Sep 12, 2016

Copy link
Copy Markdown
Member

Gem::Source error fixes Bundler 1.13.1. Bundler::Plugin::API::Source error fixes rubygems/bundler#4973 ...when merged.

@hsbt

hsbt commented Sep 13, 2016

Copy link
Copy Markdown
Member Author

@aycabta Thank you for your notification. I will try to bundler 1.13.1 when it released.

@hsbt

hsbt commented Sep 14, 2016

Copy link
Copy Markdown
Member Author

bundler-1.13.1 is still failing... :( https://travis-ci.org/ruby/rake/jobs/159734476

@hsbt hsbt changed the title Avoid to test fail caused by bundler-1.13.0 Fix test fail caused by bundler-1.13.x Sep 14, 2016
@hsbt

hsbt commented Sep 14, 2016

Copy link
Copy Markdown
Member Author

submitted rubygems/bundler#4981

@hsbt
hsbt merged commit 7b3ee9b into master Sep 16, 2016
@hsbt
hsbt deleted the fix-latest-bundler branch September 16, 2016 00:47
@hsbt hsbt mentioned this pull request Sep 16, 2016
@aycabta

aycabta commented Sep 16, 2016

Copy link
Copy Markdown
Member

I think that is the best workaround...

@aycabta aycabta mentioned this pull request Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants