:farmer: ros2cli_daemon tests failing in win rel because it can't spawn daemons

[miguelgonrod]

Generated by Generative AI

No response

Operating System:

Windows 11

ROS version or commit hash:

Rolling

RMW implementation (if applicable):

No response

RMW Configuration (if applicable):

No response

Client library (if applicable):

No response

'ros2 doctor --report' output

No response

Steps to reproduce issue

1. Go to https://ci.ros2.org/job/nightly_win_rel
2. Build a job
3. See test failing

Expected behavior

Build without test regressions

Actual behavior

Building with lots of test regressions because assert spawn_daemon() isn't spawning the daemon

Additional information

Reference Builds

• nightly_win_rel#3794

Failing tests

ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_name
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_namespace
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_node_names_and_namespaces
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_node_names_and_namespaces_with_enclaves
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_topic_names_and_types
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_service_names_and_types
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_action_names_and_types
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_publisher_names_and_types_by_node
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_subscriber_names_and_types_by_node
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_service_names_and_types_by_node
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_client_names_and_types_by_node
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_action_server_names_and_types_by_node
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_action_client_names_and_types_by_node
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_publishers_info_by_topic
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_subscriptions_info_by_topic
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_clients_info_by_service
ros2cli.ros2cli.test.test_ros2cli_daemon.test_get_servers_info_by_service
ros2cli.ros2cli.test.test_ros2cli_daemon.test_count_publishers
ros2cli.ros2cli.test.test_ros2cli_daemon.test_count_subscribers
ros2cli.ros2cli.test.test_ros2cli_daemon.test_count_clients
ros2cli.ros2cli.test.test_ros2cli_daemon.test_count_services
ros2cli.ros2cli.test.test_strategy.test_with_daemon_running
ros2cli.ros2cli.test.test_strategy.test_with_daemon_spawn
ros2cli.ros2cli.test.test_strategy.test_enforce_no_daemon

Log Output

__________________ ERROR at setup of test_count_subscribers ___________________

test\test_ros2cli_daemon.py:134: in daemon_node

    assert spawn_daemon(args=[], timeout=5.0)

E   assert False

E    +  where False = spawn_daemon(args=[], timeout=5.0)

____________________ ERROR at setup of test_count_clients _____________________

test\test_ros2cli_daemon.py:134: in daemon_node

    assert spawn_daemon(args=[], timeout=5.0)

E   assert False

E    +  where False = spawn_daemon(args=[], timeout=5.0)

____________________ ERROR at setup of test_count_services ____________________

test\test_ros2cli_daemon.py:134: in daemon_node

    assert spawn_daemon(args=[], timeout=5.0)

E   assert False

E    +  where False = spawn_daemon(args=[], timeout=5.0)

_________________ ERROR at setup of test_with_daemon_running __________________

test\test_strategy.py:35: in enforce_daemon_is_running

    assert spawn_daemon(args=[], timeout=5.0)

E   assert False

E    +  where False = spawn_daemon(args=[], timeout=5.0)

__________________ ERROR at setup of test_enforce_no_daemon ___________________

test\test_strategy.py:35: in enforce_daemon_is_running

    assert spawn_daemon(args=[], timeout=5.0)

E   assert False

E    +  where False = spawn_daemon(args=[], timeout=5.0)

================================== FAILURES ===================================

___________________________ test_with_daemon_spawn ____________________________

test\test_strategy.py:54: in test_with_daemon_spawn

    assert node._daemon_node is not None

E   assert None is not None

E    +  where None = <ros2cli.node.strategy.NodeStrategy object at 0x0000023BB9ECB320>._daemon_node

Flakyness 15 days

job_name	last_fail	first_fail	build_count	failure_count	failure_percentage
nightly_win_rel	2026-05-11	2026-05-02	4	3	75.0

The first time this error happened was in https://ci.ros2.org/job/nightly_win_rel/3783, comparing repos there is just one change in ros/ros_environment and doesn't seems related

CC: @Crola1702

[fujitatomoya]

as far as i can tell, the daemon process is in its shutdown tail, not necessarily a orphan instance.
the port is still bound by a process that has stopped serving but hasn't yet process exit.
and allow_reuse_address = True on Windows, which is intentionally False (SO_REUSEADDR is unsafe there), that said a still-bound socket on the dying daemon causes WSAEADDRINUSE. in one word, "shutdown returned"(RPC is disconnected) ≠ "port is free.", i guess...

[fujitatomoya]

@miguelgonrod

comparing repos there is just one change in ros/ros_environment and doesn't seems related

which one? according to the commit log https://github.com/ros/ros_environment/commits/rolling/, i do not see any difference.

[miguelgonrod]

Hi Fujita

--- /home/miguel/osrf/testdb/ci.ros2.org/nightly_win_rel/3782/build.repos	2026-05-12 14:36:18.550054554 -0500
+++ /home/miguel/osrf/testdb/ci.ros2.org/nightly_win_rel/3783/build.repos	2026-05-12 16:43:46.917453171 -0500
@@ -408,7 +408,7 @@ repositories:
   ros\ros_environment:
     type: git
     url: https://github.com/ros/ros_environment.git
-    version: d25b1d67df0659ed8558c6dc2853bd5b0c8ec564
+    version: fb60e89f7fc0fa0efe5a52c235c07828ace0290f

[fujitatomoya]

#1230 @miguelgonrod can you take a look?

[miguelgonrod]

Had to reopen the issue, this keeps failing

https://ci.ros2.org/job/nightly_win_rel/3804/testReport/junit/ros2cli.ros2cli.test/test_ros2cli_daemon/test_get_name/

job_name	last_fail	first_fail	build_count	failure_count	failure_percentage
nightly_win_rel	2026-05-19	2026-05-09	9	9	100.0

[miguelgonrod]

Maybe I'm wrong but these ones seems related to this issue

Reference Build

• nightly_win_rel#3883

Failing tests

• ros2cli.ros2cli.test.test_ros2cli_daemon.test_daemon_shuts_down_after_inactivity_timeout
• ros2cli.ros2cli.test.test_ros2cli_daemon.test_negative_inactivity_timeout_never_shuts_down
• ros2multicast.ros2multicast.test.test_api.test_api
• ros2multicast.ros2multicast.test.test_api.test_group_and_port
• ros2multicast.ros2multicast.test.test_api.test_port_mismatch

log Output

_______________ test_daemon_shuts_down_after_inactivity_timeout _______________

test\test_ros2cli_daemon.py:346: in test_daemon_shuts_down_after_inactivity_timeout

    assert spawn_daemon(args=[], timeout=5.0, inactivity_timeout=5)

E   assert False

E    +  where False = spawn_daemon(args=[], timeout=5.0, inactivity_timeout=5)

Flakyness 15 days

job_name	last_fail	first_fail	build_count	failure_count	failure_percentage
nightly_win_rel	2026-08-02	2026-07-19	9	9	100.0