introduce rcl_action_endpoint_info_array_t. - #1326
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde can you review this? mos of the code is init/fini and tests... but this aligns with current topic/service endpoint information. i will open the other PRs to support ros2 action info (-v).
There was a problem hiding this comment.
Pull request overview
This PR adds a new public API to query per-action endpoint details (services/topics) for action clients and servers, enabling tooling like ros2 action info to retrieve correlated endpoint metadata similar to existing topic/service graph introspection.
Changes:
- Introduces
rcl_action_endpoint_info_tandrcl_action_endpoint_info_array_tplus init/fini helpers in thercl_actiongraph API. - Adds
rcl_action_get_clients_info_by_action()/rcl_action_get_servers_info_by_action()to collect and correlate underlying service/topic endpoint info by node identity. - Extends the action graph test suite with validation and functional tests for the new APIs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rcl_action/include/rcl_action/graph.h | Adds new public structs and function declarations for action endpoint info queries. |
| rcl_action/src/rcl_action/graph.c | Implements endpoint info aggregation, correlation, and array lifecycle management. |
| rcl_action/test/rcl_action/test_graph.cpp | Adds tests covering invalid arguments and correct endpoint info results for clients/servers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
|
Pulls: #1326, ros2/rclcpp#3209, ros2/rclpy#1697, ros2/ros2cli#1262
|
|
Pulls: #1326, ros2/rclcpp#3209, ros2/rclpy#1697, ros2/ros2cli#1262
|
|
Pulls: #1326, ros2/rclcpp#3209, ros2/rclpy#1697, ros2/ros2cli#1262
|
Signed-off-by: Tomoya Fujita <fujita.tomoya@triorb.co.jp>
|
Pulls: #1326, ros2/rclcpp#3209, ros2/rclpy#1697, ros2/ros2cli#1262
|
|
Pulls: #1326, ros2/rclcpp#3209, ros2/rclpy#1697, ros2/ros2cli#1262
|
Description
part of ros2/ros2cli#1210
this introduces
rcl_action_endpoint_info_tto store the action endpoint information forros2 action info.the implementation is straight-forward as topic/service information is supported.
Fixes # (issue)
Is this user-facing behavior change?
No. just provides new functions.
Did you use Generative AI?
Yes, Claude Fable.
Additional Information