Skip to content

Upload coverage stats to codecov in specs#5

Closed
rohitpaulk wants to merge 3 commits into
add-linterfrom
add-codecov
Closed

Upload coverage stats to codecov in specs#5
rohitpaulk wants to merge 3 commits into
add-linterfrom
add-codecov

Conversation

@rohitpaulk

Copy link
Copy Markdown
Owner

No description provided.

@codecov

codecov Bot commented Nov 23, 2017

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (add-linter@1f1229a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             add-linter       #5   +/-   ##
=============================================
  Coverage              ?   98.77%           
=============================================
  Files                 ?       12           
  Lines                 ?      571           
  Branches              ?        0           
=============================================
  Hits                  ?      564           
  Misses                ?        7           
  Partials              ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1229a...296bd06. Read the comment docs.

rohitpaulk and others added 2 commits November 29, 2017 09:14
* Add rubocop (style linter), run as part of default rake task

* Generate rubocop_todo.yml

* Autocorrect simple cops

* Use consistent style for indenting hashes

* Auto-correct cops

* Avoid redefining #stub via attr_accessor

* Avoid assignment within condition

* Avoid suppressing exception in spec_helper.rb

* Auto-correct cops

* Autocorrect symbol arrays

* Auto-correct string literals

* Auto-correct quotes within interpolation

* Autocorrect raising exceptions

* Avoid using semi-colon as a separator

* Set target ruby version

* Auto-correct Proc style

* Specify 'verbose' style for Hash#has_key?

* Allow parallel assignment

* Allow 6 digits without underscores

* Allow mutable constants

This behaviour could've been relied on by users, not worth changing.

* Avoid multi-line if modifier usage

* Use parentheses for all method definitions

* Allow 1.9 hash syntax in specs

* Allow one-liners to be wrapped in conditionals

* Allow % for formatting

* Use each_with_object instead of inject

* Allow DateTime in specs

* Remove colon method call

* Allow bracket symbol arrays

* Disable doc checks

* Allow all block delimiters in specs

* Remove non-ascii quote in comment

* Allow is_requesting? as an exception for predicate names

* Disable BracesAroundHashParameters check

* Move legit items from .rubucop_todo.yml to .rubocop.yml

* Disable metrics check for specs
@rohitpaulk rohitpaulk closed this Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants