Skip to content

fix(aws): tag IAM role/instance-profile and spot ASG with mapt resource tags - #891

Open
ppitonak wants to merge 1 commit into
mainfrom
tags
Open

fix(aws): tag IAM role/instance-profile and spot ASG with mapt resource tags#891
ppitonak wants to merge 1 commit into
mainfrom
tags

Conversation

@ppitonak

@ppitonak ppitonak commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

The EC2 role, instance profile, spot Auto Scaling Group, and on-demand instances' root EBS volumes were untagged, making orphaned resources (from interrupted destroys) hard to identify and clean up. Also fixes a naming typo (instance-profie -> instance-profile).

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 54 minutes.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 081263e9-678b-407c-8e31-7ba4283641e1

📥 Commits

Reviewing files that changed from the base of the PR and between 2f456f1 and bdad4d5.

📒 Files selected for processing (5)
  • pkg/provider/aws/action/snc/snc.go
  • pkg/provider/aws/modules/bastion/bastion.go
  • pkg/provider/aws/modules/ec2/compute/compute.go
  • pkg/provider/aws/modules/iam/iam.go
  • pkg/provider/aws/modules/mac/machine/machine.go
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@ppitonak
ppitonak marked this pull request as ready for review August 26, 2026 12:46
… volumes with mapt resource tags

The EC2 role, instance profile, spot Auto Scaling Group, and on-demand
instances' root EBS volumes were untagged, making orphaned resources
(from interrupted destroys) hard to identify and clean up. Also fixes
a naming typo (instance-profie -> instance-profile).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Pavol Pitonak <ppitonak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant