Skip to content

chore: Bump go to 1.22#804

Merged
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:masterfrom
svghadi:go-1.22
Nov 8, 2024
Merged

chore: Bump go to 1.22#804
openshift-merge-bot[bot] merged 2 commits into
redhat-developer:masterfrom
svghadi:go-1.22

Conversation

@svghadi

@svghadi svghadi commented Nov 6, 2024

Copy link
Copy Markdown
Member

What does this PR do / why we need it:
Bump golang to 1.22

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@svghadi

svghadi commented Nov 6, 2024

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@svghadi

svghadi commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

/retest

@iam-veeramalla

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Nov 7, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Nov 7, 2024
@svghadi

svghadi commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

@varshab1210 - Are these known failures?

        --- FAIL: kuttl/harness/1-067_validate_redis_secure_comm_no_autotls_ha (162.10s)
        --- FAIL: kuttl/harness/1-066_validate_redis_secure_comm_no_autotls_no_ha (37.84s)

@varshab1210

Copy link
Copy Markdown
Member

@varshab1210 - Are these known failures?

        --- FAIL: kuttl/harness/1-067_validate_redis_secure_comm_no_autotls_ha (162.10s)
        --- FAIL: kuttl/harness/1-066_validate_redis_secure_comm_no_autotls_no_ha (37.84s)

req: Multiple digest or unknown options: -sha256 and -sha256

Could you please remove one of the sha256 options? That should fix the failure

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
@openshift-ci openshift-ci Bot removed the lgtm label Nov 7, 2024
@svghadi

svghadi commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

/retest

2 similar comments
@svghadi

svghadi commented Nov 8, 2024

Copy link
Copy Markdown
Member Author

/retest

@svghadi

svghadi commented Nov 8, 2024

Copy link
Copy Markdown
Member Author

/retest

@varshab1210

Copy link
Copy Markdown
Member

LGTM, thanks

@varshab1210

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Nov 8, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit afcbfa4 into redhat-developer:master Nov 8, 2024
@svghadi svghadi deleted the go-1.22 branch November 8, 2024 11:01
varshab1210 pushed a commit to nmirasch/gitops-operator that referenced this pull request Jul 23, 2025
* Bump go to 1.22

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

* Fix kuttl test

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>

---------

Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants