Update dark mode section#108
Open
galactic-magpie wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
💸 TL;DR
The UI Simulator color scheme toggle temporarily forces the color scheme of the webview dialog, overriding the user's reddit theme to enable the dev to view their app in light and dark mode. This only works if the app has colors set for dark mode. Previous docs version only provided an example of doing this via CSS media query; this PR just adds an example of using Tailwind's
darkclass, which is essentially the same thing, but aligns more with our app templates.(All our app templates should already have this dark class built in to the basic UI, and devs will need to add it to all additional UI)
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks