Skip to content

Translate "Thinking in React"#8

Merged
gedeagas merged 6 commits into
reactjs:masterfrom
resir014:feature/id-thinking-in-react
Feb 14, 2019
Merged

Translate "Thinking in React"#8
gedeagas merged 6 commits into
reactjs:masterfrom
resir014:feature/id-thinking-in-react

Conversation

@resir014
Copy link
Copy Markdown
Member

@resir014 resir014 commented Feb 10, 2019

This is the translated version of Thinking in React. I took some of the translations already available on the Crowdin, with some changes to follow the style guide. I'm going to add some personal notes for the reviewers to look at.

Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
@resir014
Copy link
Copy Markdown
Member Author

First pass of code review done, mas.

Copy link
Copy Markdown
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll only need to adjust several italicized words and common terms regarding to the glossary and we're good to go.. Thanks mas @resir014 !

Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
Comment thread content/docs/thinking-in-react.md Outdated
@resir014
Copy link
Copy Markdown
Member Author

@regalius Okay, done mas.

Copy link
Copy Markdown
Member

@gedeagas gedeagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @resir014 🎉. Thank you for contributing

@gedeagas gedeagas merged commit ef53970 into reactjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants