Server side rendered components require server restart to take effect

[WonSong]

Using ASP.NET Core 2.1
Webpack 4
Typescript 2.9

[Daniel15]

@WonSong - If you attach a debugger, do you see messages like this when you change the files?

[JSPool] Watched file 'foo.js' changed

@dustinsoftware Do you have any ideas on this? We do configure JSPool to recycle the pool on change:

React.NET/src/React.Core/JavaScriptEngineFactory.cs

Lines 93 to 94 in c90a4a6

	WatchPath = _fileSystem.MapPath("~/"),
	WatchFiles = allFiles

And then JSPool uses a FileSystemWatcher:

https://github.com/Daniel15/JSPool/blob/master/src/JSPool/FileWatcher.cs#L90-L102

Perhaps we're not passing the file names correctly, or passing the wrong path, or something like that.

[dustinsoftware]

I was able to repro this issue with webpack 4. Try downgrading to webpack 3 and see if you're still having problems.

I'm still investigating but want to rule out changes within webpack itself.

[dustinsoftware]

The webpack 4 issue I thought I was encountering was a red herring, webpack 4 changed the default destination to dist so my changes weren't going to the right folder like I thought they were :) One thing I didn't ask earlier, are you using Windows or another platform?

[WonSong]

On Windows

[WonSong]

I created a sample app, but seeing the same issue on Mac. Here's the repo: https://github.com/WonSong/ReactDotNetTypeScriptWebpackDemo

[dustinsoftware]

Thanks @WonSong. I'll look at this in the next few days.

[vezaynk]

I have wasted a lot of time struggling with this. Is there an ETA?

[dustinsoftware]

Haven’t had time to look at this one yet. Details about your environment would be helpful Can you paste your packages.config in this issue? What version of asp.net and .net framework are you on? 32 bit or 64 bit process?

…

On Fri, Jul 20, 2018 at 12:52, Slava Knyazev ***@***.***> wrote: I have wasted a lot of time struggling with this. Is there an ETA? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#554 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5hFgGlxDMJj3idtx7Rarr0z-GNNqqDks5uIjT8gaJpZM4Uub8F> .

[vezaynk]

I no longer have a project using it. The general buginess and unreliability of it made me switch away.

[dustinsoftware]

Glad you found another solution that fits your needs.

…

On Fri, Jul 20, 2018 at 14:08, Slava Knyazev ***@***.***> wrote: I no longer have a project using it. The general buginess and unreliability of it made me switch away. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#554 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5hFpPtir7llBnHBe0M7XidPYHGFeY3ks5uIkbggaJpZM4Uub8F> .

[dustinsoftware]

Sorry, that response may have come across as terse. I intend to debug this problem but can’t do so without detailed information about the environment this library runs in, since the bug hasn’t occurred when I have attempted to repro it.

[WonSong]

i still have this issue in ASP.NET Core MVC 2.1.301 both on 64bit latest MacoOs and 64bit windows 10. Still using same template as the one I provided above.

[dustinsoftware]

Ok, so here's what I did to try and repro the issue (no luck). Please let me know if I am missing something. .NET Core 2.1 on OS X.

1. Cloned your repo
2. yarn to restore packages
3. yarn start to run webpack
4. dotnet run to start the dev server
5. Opened the browser, saw components render successfully
6. Made a component render change in Hello.tsx
7. Observe that the server-rendered change worked when reloading the window

[vezaynk]

Interestingly, once I disabled the re-use of the rendering engine, it ceased to be an issue. Could it be that a renderer is persisting through the updates?