Skip to content

Add Render deployment section - #6695

Merged
amyrlam merged 1 commit into
react:masterfrom
anurag:ag/render
Apr 8, 2019
Merged

Add Render deployment section#6695
amyrlam merged 1 commit into
react:masterfrom
anurag:ag/render

Conversation

@anurag

@anurag anurag commented Mar 20, 2019

Copy link
Copy Markdown
Contributor

Screenshot:

image

@anurag
anurag requested review from amyrlam and iansu as code owners March 20, 2019 19:02
@facebook-github-bot

facebook-github-bot commented Mar 20, 2019

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Mar 20, 2019

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@anurag

anurag commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

Additional context: Render serves over 7 million requests/day as of late March 2019.

@anurag

anurag commented Apr 8, 2019

Copy link
Copy Markdown
Contributor Author

If it helps, here's the Render deployment section on Gatsby: https://www.gatsbyjs.org/docs/deploying-to-render/

@amyrlam amyrlam self-assigned this Apr 8, 2019
petetnt
petetnt approved these changes Apr 8, 2019
View reviewed changes

@petetnt petetnt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyrlam amyrlam added this to the 3.0 milestone Apr 8, 2019
@amyrlam
amyrlam merged commit a1d6aef into react:master Apr 8, 2019
@anurag

anurag commented Apr 8, 2019 via email

Copy link
Copy Markdown
Contributor Author

@amyrlam

amyrlam commented Apr 8, 2019

Copy link
Copy Markdown
Contributor

thanks for the PR! 💯

@anurag
anurag deleted the ag/render branch April 8, 2019 23:57
This was referenced Apr 8, 2019
Merged
Closed
Closed
@lock lock Bot locked and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam
@iansu iansu Awaiting requested review from iansu
1 more reviewer
@petetnt petetnt petetnt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@amyrlam amyrlam

Labels

CLA Signed tag: documentation

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@anurag @facebook-github-bot @amyrlam @petetnt