Skip to content

Bumped jest version to 22.4.1#4362

Merged
andriijas merged 2 commits into
react:nextfrom
chad-codes:patch-1
Apr 27, 2018
Merged

Bumped jest version to 22.4.1#4362
andriijas merged 2 commits into
react:nextfrom
chad-codes:patch-1

Conversation

@chad-codes

Copy link
Copy Markdown

Bumped jest version. Is this all that needs to be done? I'm unfamiliar with the whole project structure so if there's more that needs to be done, please advise.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon

gaearon commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

Please also update it at the top level of the repo and in all other packages that rely on it as devDependency.

@gaearon gaearon added this to the 2.0.0 milestone Apr 25, 2018
@chad-codes

Copy link
Copy Markdown
Author

@gaearon It looks like the build timed out or something. Please advise.

@iansu

iansu commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

The build passed on Appveyor. It seems like all recent builds have been timing out on Travis when running with Node 6.

@gaearon

gaearon commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

Even outside this PR? Was some PR the catalyst for this or is it a Travis issue?

@iansu

iansu commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

I'm seeing similar issues with #4361 and #4350. The Node 6 kitchensink build either times out on Travis or ends with EOF or broken pipe errors.

@andriijas

andriijas commented Apr 26, 2018

Copy link
Copy Markdown
Contributor

When they said node 6 is reaching EOL they really meant it 😂 (could it be that some dependency have dropped node 6 support?)

@iansu

iansu commented Apr 26, 2018

Copy link
Copy Markdown
Contributor

It's actually Node 4 that's EOL at the end of April.

@andriijas

Copy link
Copy Markdown
Contributor

Ah, right. node 6 is just entering maintenance mode. No idea why the CI is missbehaving.

@andriijas andriijas merged commit 32eebfe into react:next Apr 27, 2018
@chad-codes chad-codes deleted the patch-1 branch April 27, 2018 17:15
kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request May 2, 2018
* upstream/next: (35 commits)
  Update envinfo and issue template (react#4375)
  Update sass-loader to 7.0.1 (react#4376)
  Support package distribution tags (react#4350)
  fix broken css module support in prod (react#4361)
  Bumped jest version to 22.4.1 (react#4362)
  bump babel 7 to beta 46
  bump lint-staged to node 10 compatible version
  documentation: Added License to the README.md (react#4294)
  Bump `fsevents`. (react#4331)
  Fix typo in e2e-simple.sh comment (react#4323)
  Add Sass loader (react#4195)
  Fix some typos in README.md (react#4286)
  Added learnstorybook.com to Storybook links (react#4298)
  Document multiple build environments via `env-cmd` react#4071 (react#4117)
  Fixed link to CSS imports blog post
  Update CSS Modules localIndetName (react#4192)
  Enable loose mode for `class-properties` (react#4248)
  bump babel 7 beta (react#4253)
  Small typo fix react#4217
  Changelog for 1.1.4
  ...
kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request May 2, 2018
* next: (35 commits)
  Update envinfo and issue template (react#4375)
  Update sass-loader to 7.0.1 (react#4376)
  Support package distribution tags (react#4350)
  fix broken css module support in prod (react#4361)
  Bumped jest version to 22.4.1 (react#4362)
  bump babel 7 to beta 46
  bump lint-staged to node 10 compatible version
  documentation: Added License to the README.md (react#4294)
  Bump `fsevents`. (react#4331)
  Fix typo in e2e-simple.sh comment (react#4323)
  Add Sass loader (react#4195)
  Fix some typos in README.md (react#4286)
  Added learnstorybook.com to Storybook links (react#4298)
  Document multiple build environments via `env-cmd` react#4071 (react#4117)
  Fixed link to CSS imports blog post
  Update CSS Modules localIndetName (react#4192)
  Enable loose mode for `class-properties` (react#4248)
  bump babel 7 beta (react#4253)
  Small typo fix react#4217
  Changelog for 1.1.4
  ...
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock Bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants