Skip to content

fix(android): properly handle errors#2113

Merged
thymikee merged 1 commit intomainfrom
fix/properly-pass-error
Oct 19, 2023
Merged

fix(android): properly handle errors#2113
thymikee merged 1 commit intomainfrom
fix/properly-pass-error

Conversation

@szymonrybczak
Copy link
Copy Markdown
Collaborator

@szymonrybczak szymonrybczak commented Oct 10, 2023

Summary:

Currently we're not displaying errors if they other than we expect, so even we're not showing errors that we return inside CLI - which leads to situations like this one #2105, when user don't know what to do because the error is only "error Failed to install the app".

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-android --mode=randomMode

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak szymonrybczak changed the title fix(android): properly set error fix(android): properly handle errors Oct 10, 2023
@szymonrybczak
Copy link
Copy Markdown
Collaborator Author

Definitely we need more tests in that part of codebase.

@thymikee thymikee merged commit 5ef4130 into main Oct 19, 2023
@thymikee thymikee deleted the fix/properly-pass-error branch October 19, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants