feat: add long press mixin#545
Merged
Merged
Conversation
che-effe
requested review from
ImCoolNowRight,
anthony9187,
cee-money,
ctoddy,
erautenberg,
joshhowenstine and
soumyaloka
as code owners
October 21, 2024 18:44
|
|
che-effe
marked this pull request as draft
October 21, 2024 18:45
ImCoolNowRight
left a comment
ImCoolNowRight
left a comment
Contributor
There was a problem hiding this comment.
Just a few thoughts on the mixin portion. I know the rest is still WIP.
che-effe
marked this pull request as ready for review
October 22, 2024 21:09
ImCoolNowRight
approved these changes
Oct 23, 2024
ImCoolNowRight
force-pushed
the
LUI-60/LongPress
branch
from
October 23, 2024 20:23
71cc605 to
a6e0141
Compare
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 23, 2024
# [@lightningjs/ui-components-v2.24.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.23.3...@lightningjs/ui-components-v2.24.0) (2024-10-23) ### Bug Fixes * move type export up ([#547](#547)) ([55e8d4c](55e8d4c)) * **ScrollWrapper:** bubble focus events and remove signals ([#546](#546)) ([ceec205](ceec205)) ### Features * add long press mixin ([#545](#545)) ([11d2368](11d2368))
Collaborator
|
🎉 This PR is included in version @lightningjs/ui-components-v2.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 23, 2024
# [@lightningjs/ui-components-test-utils-v1.6.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-test-utils-v1.5.0...@lightningjs/ui-components-test-utils-v1.6.0) (2024-10-23) ### Bug Fixes * move type export up ([#547](#547)) ([55e8d4c](55e8d4c)) ### Features * add long press mixin ([#545](#545)) ([11d2368](11d2368))
Collaborator
|
🎉 This PR is included in version @lightningjs/ui-components-test-utils-v1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates a Long Press handler mixin that can work with any key. Component with this mixin has to set a threshold in ms to define long press length and also have a signal listers for
longPressHitsignal.Handler method supplied will be called when long press threshold is reached and will recieve the key value that was pressed.
Client can then execute as they wish on any long pressed key they desire.
References
LUI-60
Testing
View
withLongPressstory in storybook and make sure the component works as described above.Checklist