fix: move type export up#547
Merged
Merged
Conversation
ImCoolNowRight
requested review from
anthony9187,
cee-money,
ctoddy,
erautenberg,
joshhowenstine and
soumyaloka
as code owners
October 22, 2024 17:40
joshhowenstine
approved these changes
Oct 22, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 23, 2024
# [@lightningjs/ui-components-v2.24.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.23.3...@lightningjs/ui-components-v2.24.0) (2024-10-23) ### Bug Fixes * move type export up ([#547](#547)) ([55e8d4c](55e8d4c)) * **ScrollWrapper:** bubble focus events and remove signals ([#546](#546)) ([ceec205](ceec205)) ### Features * add long press mixin ([#545](#545)) ([11d2368](11d2368))
Collaborator
|
🎉 This PR is included in version @lightningjs/ui-components-v2.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 23, 2024
# [@lightningjs/ui-components-test-utils-v1.6.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-test-utils-v1.5.0...@lightningjs/ui-components-test-utils-v1.6.0) (2024-10-23) ### Bug Fixes * move type export up ([#547](#547)) ([55e8d4c](55e8d4c)) ### Features * add long press mixin ([#545](#545)) ([11d2368](11d2368))
Collaborator
|
🎉 This PR is included in version @lightningjs/ui-components-test-utils-v1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a warning displayed when starting Storybook indicating that the
typesbeing exported will not be used because TypeScript will resolve to using one of the JavaScript exports before it since they technically match:This PR just moves the
typesto the top of the exports in relevantpackage.jsonfiles.References
N/A
Testing
Start Storybook and confirm that they above error does not show in your console.
Checklist