refactor(apps): +db-env-create --sync-data → Type:bool - #54
Merged
Conversation
原实现用 string + Enum["true","false"] + == "true" 模拟 bool，啰嗦且非惯用。 改为 Type:bool（rctx.Bool）：传 --sync-data 即开启、省略为 false。 同步更新测试、cli_e2e dry-run、skill 文档。 Change-Id: I3068e0577fa20a7cbaf414ca9af3d197f6ae8049
github-actions
Bot
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
apps_db_env_create.go的--sync-data用string + Enum["true","false"]模拟 bool，再== "true"折算 —— 啰嗦且非 CLI 惯用法。修复
Type: "bool"，body 用rctx.Bool("sync-data")--sync-data即开启、省略为 false（idiomatic bool）go test ./shortcuts/apps/ ./tests/cli_e2e/apps/全绿。