Don't use display_identifier as OpenID identifier. - #4
Closed
nov wants to merge 1 commit into
Closed
Conversation
It's reusable and not secure.
Contributor
|
Sadly, this issue has been open for a long time. I'd really like to finally see this issue fixed, because as it stands, everyone is Doing It Wrong. |
Author
|
Umm, I see. In my project, I spent about 1.5 years to migrate legacy Yahoo! OpenID Identifier (without fragments) to new one. |
grosser
referenced
this pull request
in grosser/open_id_authentication
Sep 17, 2013
Clarifying the AX data section of the readme.
Author
|
openid2 is dead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
display_identifier isn't OpenID identifier.
If a user deleted his OP account, display_identifier could be assigned to another user who got the same username at least at Yahoo!
Simply, use "identity_url".