use session_class in database tasks - #237
Open
chaadow wants to merge 1 commit into
Open
Conversation
Author
|
@rafaelfranca also would you mind me using |
Member
|
No. Let's use in batches as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rafaelfranca BTW I believe this can be simplfied to only
where( created_at < ?, cutoff_period)the example in the rails guides, uses a different period for each column
where(updated_at: ...time.ago).or(where(created_at: ...2.days.ago)).delete_all)( check : https://guides.rubyonrails.org/security.html#session-expiry )I'm in favor of only keeping
created_atand adding an index on that column instead of an index onupdated_atbecause adding an index onupdated_at( a column which is constantly/naturally updated almost every single time) prevents Heap Only Tuple (HOT ) updates on PostgreSQL, which can lead to write amplification / more WAL etc...