docs(coil): fix seam-ledger rows the #71 rename left pointing at t3x names - #116
Merged
Conversation
…names Four rows in the ledger still described the update-delivery seam with its pre-rename identifiers: a `t3xUpdate` bridge object, four `t3x:update-*` channel constants, three `t3xUpdate` handlers, and interfaces at `src/t3x/updateDelivery.ts`. None of those exist — the code calls them `coilUpdate`, `coil:update-*`, `getCoilUpdateState` / `restartIntoUpdate` / `dismissCoilUpdate`, and `src/coil/updateDelivery.ts`. The ledger is the fork's map of its own upstream surface, so a row naming a symbol that no longer exists is worse than no row: it reads as verified. Not a blanket rename. `scripts/t3x/**`, `.github/workflows/t3x-*.yml` and the `t3x-sync` label all kept the old name through #71, and line 49's note about the rename itself is correct history. Only source namespaces and docs moved. Also corrects the header total, which read +2621 against a measured +2622. That is the third time the totals have been wrong when checked (+1616 vs +1627 on 08-05), which is the file's own "regenerate before trusting it" advice earning its place. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four rows in
docs/coil/SEAMS.mdstill described the update-delivery seam using its pre-renameidentifiers. None of them exist in the tree any more:
packages/contracts/src/ipc.tst3xUpdate,src/t3x/updateDelivery.tscoilUpdate,src/coil/updateDelivery.tsapps/desktop/src/preload.tst3xUpdatebridge objectcoilUpdateapps/desktop/src/ipc/channels.tst3x:update-*constantscoil:update-*apps/desktop/src/ipc/DesktopIpcHandlers.tst3xUpdatehandlerscoilUpdatehandlers, now namedThe ledger is the fork's map of its own upstream surface. A row naming a symbol that no longer
exists is worse than no row at all, because it reads as verified.
Deliberately not a blanket rename.
scripts/t3x/**,.github/workflows/t3x-*.ymland thet3x-synclabel all kept the old name through #71, and line 49's note about the rename itself iscorrect history. Only the source namespaces and docs moved, so
t3xin a path is not automaticallystale.
Every identifier the file now claims was grepped against the tree before committing:
coilUpdate,coil/updateDelivery.ts,coil:update-state,getCoilUpdateState,restartIntoUpdate,dismissCoilUpdate— all present.Header total
Also corrects
+2621to+2622. Regenerated againstorigin/mainper the file's own Regeneratingsection (merge-base
196c8ea0d, matching the header;HEAD == origin/main): 51 files,+2622 / -1093. File count and deletions were already right.
That is the third time these totals have been wrong when checked —
+1616against a real+1627on 2026-08-05, now this. The file's instruction to regenerate before trusting it keeps being
correct.
Verification
Docs-only; no code paths touched.
vp fmtran clean via the pre-commit hook.Model: Claude Opus 5 (1M context). Harness: Claude Code.
🤖 Generated with Claude Code