fix(coil): verify every packaged layer, and fail on layers the gate cannot see (#102) - #106
Merged
Conversation
…annot see (#102) Upstream's Windows server.asar split (this sync) broke the release's bundle-verify gate both ways at once: the server graph silently stopped being scanned, and node-pty — mentioned only inside main.cjs's embedded WSL heredoc scripts, loadable from the sidecar where it genuinely lives — was reported unresolvable, failing a shippable build (release run 31837711136, publish skipped). The view now merges a sibling resources/server.asar (+ .unpacked) into the packaged-file map, so sidecar bundles are scanned again and sidecar packages resolve. And every FIRST_PARTY_BUNDLE_DIRS entry must contribute at least one scanned bundle — a packaging-topology change that hides a layer is now an error instead of an empty green result, which is the 'guard that cannot fail' shape #97 already taught us once. Also corrects the three comments still teaching the disproven GITHUB_REPOSITORY="" mechanism (main.ts, UpdateToast.tsx) and the workflow step's stale Windows-topology claim. Fixes #102. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
radroid
added a commit
that referenced
this pull request
Aug 14, 2026
…hipped app cannot reach (#107) The sidecar-aware gate (#102, PR #106) surfaced two more phantom requirements on Windows: @effect/platform-bun and @effect/sql-sqlite-bun, imported by the server bundle only behind Bun-runtime detection. The shipped app always runs the server under Node (ELECTRON_RUN_AS_NODE), so the branch is unreachable, and upstream's Windows sidecar deliberately stages neither — their absence broke release run 31839839479 without breaking anything real. The macOS artifact only carries them because its staging installs the full production dependency set. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-08-14 sync imported upstream's Windows
server.asarsplit, which broke the release's bundle-verify gate in both directions at once — and red release run 31837711136 (publish skipped, nothing shipped) is the proof:app.asar(+.unpacked), which now holds just the Electron main-process bundle — the entire server closure was unverified, with no signal.node-ptyappears inmain.cjsonly inside embedded WSL heredoc strings (the regex scanner cannot tell), and it genuinely lives in the sidecar for the WSL path — but the sidecar was invisible, so the gate reported MODULE_NOT_FOUND.Fix:
verifyPackagedAppmerges a siblingresources/server.asar(+ its.unpacked) into the packaged view: sidecar bundles are scanned again, and packages that live there resolve.FIRST_PARTY_BUNDLE_DIRSentry must contribute ≥1 scanned bundle, else the gate fails with a topology-changed error. A layer the checker cannot see can never silently pass again (the fix(coil): restore the release, and make two of its checks capable of failing #97 lesson, second occurrence).GITHUB_REPOSITORY=\"\"silencing mechanism, and the workflow step's stale topology claim.Verified: scripts suite 318/318 green (with
env -u ELECTRON_RUN_AS_NODE— the session env otherwise contaminates spawned-command assertions), repo typecheck 0 errors, fmt clean.Fixes #102.
🤖 Generated with Claude Code