fix(coil): verify gate must not require unreachable Bun-runtime imports - #107
Merged
Conversation
…hipped app cannot reach The sidecar-aware gate (#102, PR #106) surfaced two more phantom requirements on Windows: @effect/platform-bun and @effect/sql-sqlite-bun, imported by the server bundle only behind Bun-runtime detection. The shipped app always runs the server under Node (ELECTRON_RUN_AS_NODE), so the branch is unreachable, and upstream's Windows sidecar deliberately stages neither — their absence broke release run 31839839479 without breaking anything real. The macOS artifact only carries them because its staging installs the full production dependency set. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #106 (issue #102). The now-sidecar-aware gate flagged
@effect/platform-bunand@effect/sql-sqlite-bunas unresolvable on Windows (release run 31839839479). Both are dynamic imports behind Bun-runtime detection (typeof Bun !== \"undefined\"inserver.ts,process.versions.buninpersistence/Layers/Sqlite.ts); the shipped app always runs the server under Node viaELECTRON_RUN_AS_NODE, and upstream's Windows sidecar deliberately omits both. Documented allowlist + pinning test (scripts suite 319/319 withenv -u ELECTRON_RUN_AS_NODE).🤖 Generated with Claude Code