net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency

[pkrian]

The current implementation configures the PTP reference clock (clk_ptp_ref) to its maximum supported frequency in order to improve timestamp resolution.

While higher clock rates benefit PTP/gPTP accuracy, forcing the PTP reference clock to operate at maximum frequency results in increased power consumption, as the clock remains at this rate irrespective of actual runtime requirements.

On power-sensitive platforms and in use cases where ultra-high timestamp precision is not required, this leads to unnecessary power overhead.

Update the driver to restore the nominal/default clock configuration for clk_ptp_ref, allowing the platform to operate at its baseline frequency (e.g., ~19.2 MHz). This reduces power consumption while maintaining functional correctness for standard PTP operation.

Higher clock frequencies can be enabled through targeted configuration if improved timestamp resolution is required for specific applications.

[qswat-orbit-external]

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

[qlijarvis]

PR #619 — validate-patch

PR: #619

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message or PR description
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix
4. PR present in qcom-next: Not checked — validation blocked by missing upstream reference

Verdict: ❌ — click to expand

Patch Validation Report

PR: #619 - net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency
Upstream: (none found)
Verdict: ❌ FAIL

Reason

No lore.kernel.org link was found in the PR description or commit message.
This skill only validates patches against a lore.kernel.org source.

The commit message lacks:

• Any lore.kernel.org URL (Link:, Patch-mainline:, or inline reference)
• Vendor prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:)
• Signed-off-by trailer
• Fixes: tag (if this addresses a bug)

Commit Message

Check	Status	Note
Subject matches upstream	⏭️ N/A	No upstream link to compare
Body preserves rationale	⏭️ N/A	No upstream link to compare
Fixes tag present/correct	❌	Missing (if this fixes a bug/regression)
Authorship preserved	⏭️ N/A	No upstream link to compare
Backport note (if applicable)	⏭️ N/A	No upstream link to compare
Signed-off-by present	❌	Missing

Diff

File	Status	Notes
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c	⏭️	Removes ethqos_ptp_clk_freq_config function (18 lines deleted) — cannot validate without upstream reference

Issues

1. Missing lore link: No Link: https://lore.kernel.org/... tag in commit message
2. Missing vendor prefix: Commit subject has no prefix (UPSTREAM:/FROMLIST:/BACKPORT:/QCLINUX:/etc.)
3. Missing Signed-off-by: No DCO sign-off present
4. Missing Fixes tag: If this addresses a regression or bug, a Fixes: tag should reference the commit that introduced the issue

Recommendation

Cannot validate without upstream reference. Before merging, the commit must be updated with one of:

1. If this is an upstream patch (posted to netdev@vger.kernel.org or already merged):

   • Add prefix: UPSTREAM: (if merged) or FROMLIST: (if posted but not merged)
   • Add Link: https://lore.kernel.org/r/<message-id> to commit message
   • Add Signed-off-by: Kiran Patchala <pkiran@qti.qualcomm.com>
   • Re-run validation

2. If this is a vendor-specific change (not intended for upstream):

   • Add prefix: QCLINUX: net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency
   • Add Signed-off-by: Kiran Patchala <pkiran@qti.qualcomm.com>
   • Add rationale for why this is vendor-only (e.g., "Qualcomm-specific power optimization")

3. If this reverts a previous commit:

   • Use Revert "..." format in subject
   • Add prefix before Revert (e.g., QCLINUX: Revert "...")
   • Reference the commit being reverted

Verdict

❌ FAIL — Missing mandatory upstream reference or vendor prefix. Commit cannot be validated or merged in current form.

Final Summary

1. Lore link present: No — no lore.kernel.org link found in commit message or PR description
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix
4. PR present in qcom-next: Not checked — validation blocked by missing upstream reference

[qlijarvis]

PR #619 — checker-log-analyzer

PR: #619
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26738012487

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	Missing Signed-off-by line
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Missing required subject prefix (if not targeting qcom-next/qcom-next-staging)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #619 - net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26738012487

Checker	Result	Summary
checkpatch	❌	Missing Signed-off-by line
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No devicetree changes
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Missing required subject prefix (if not targeting qcom-next/qcom-next-staging)

---

❌ checkpatch

Root cause: Commit 76bac09 is missing the mandatory Signed-off-by: line.

Failure details:

ERROR: Missing Signed-off-by: line(s)

76bac092b9f0c18c8f79e879dd2c0fb8e8d147c2 total: 1 errors, 0 warnings, 0 checks, 30 lines checked

Commit 76bac092b9f0 ("net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency") has style problems, please review.

Fix: Add the Signed-off-by: line to the commit message:

git rebase -i a1f6d71a69b09d36f9af071759877e6d33b572fa
# Mark commit 76bac092b9f0 as 'edit'
git commit --amend --signoff --no-edit
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a1f6d71a69b09d36f9af071759877e6d33b572fa..76bac092b9f0c18c8f79e879dd2c0fb8e8d147c2

---

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency
Commit summary does not start with a required prefix

Fix: The commit subject must start with one of the allowed prefixes. Based on the nature of this change (power optimization for Qualcomm platform), choose the appropriate prefix:

• If this patch has been posted to the upstream mailing list (netdev/lkml), use FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL
• If this patch is already merged upstream, use UPSTREAM: and add a Link: tag
• If this is a vendor-specific change with no upstream equivalent, use QCLINUX: (note: this will still fail check-patch-compliance, which is a known limitation)

Example fix for a posted patch:

git rebase -i a1f6d71a69b09d36f9af071759877e6d33b572fa
# Mark commit as 'edit'
git commit --amend -m "FROMLIST: net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency

<original commit body>

Link: https://lore.kernel.org/...
Signed-off-by: Kiran Patchala <pkiran@qti.qualcomm.com>"
git rebase --continue

---

❌ tag-check

Root cause: Subject line does not start with a required prefix tag.

Applies when: The PR target branch is not qcom-next or qcom-next-staging.

Note: Unable to determine the target branch from available logs. If this PR targets any branch other than qcom-next or qcom-next-staging, the subject prefix is mandatory.

Failure details:

Commit 76bac092b9f0 ("net: stmmac: dwmac-qcom-ethqos: Restore nominal clk_ptp_ref frequency")
Subject line does not start with a required prefix.

Required prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:

Fix: Same as check-patch-compliance fix above. Add the appropriate prefix based on the patch origin.

---

Verdict

2-3 blockers must be fixed before merge:

1. Critical: Add Signed-off-by: line (checkpatch ERROR)
2. Critical: Add required subject prefix (check-patch-compliance + tag-check)
3. Recommended: Add Link: tag if the patch has an upstream reference

The code change itself is clean (no sparse issues, no DT/UAPI changes). Once the commit metadata is corrected, this should be ready to merge.

[shashim-quic]

submit patch upstream and bring it as FROMLIST.