Quote and encode IMAP mailbox names#108
Open
mpscholten wants to merge 3 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.github.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaa892f8bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mpscholten
force-pushed
the
upstream/imap-mailbox-quoting
branch
from
cbfe450 to
0e242d9
Compare
…ox-quoting # Conflicts: # test/IMAPParsersTest.hs
…ox-quoting # Conflicts: # HaskellNet.cabal
Contributor
Author
|
@qnikst any thoughts on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for IMAP mailbox handling. This is based on upstream
masterafter #101 merged, so the remaining diff is focused on mailbox quoting, modified UTF-7 handling, and the related tests.Changes:
SELECT,EXAMINE,CREATE,DELETE,RENAME,SUBSCRIBE,UNSUBSCRIBE,STATUS,APPEND,COPY,MOVE)LIST/LSUBRegression coverage:
Entwürfe->Entw&APw-rfeA&B->A&-BEntw&APw-rfeandA&-BBefore wiring the fix,
cabal test imap-parsers --test-show-details=directfailed on the new command-byte and LIST decoding tests.Validation:
nix shell nixpkgs#cabal-install nixpkgs#ghc --command cabal test imap-parsers --test-show-details=directnix shell nixpkgs#cabal-install nixpkgs#ghc --command cabal build allnix shell nixpkgs#cabal-install nixpkgs#ghc --command cabal check(only the existingCHANGELOGdoc-place warning remains)git diff --checkRelationship to #101: