Skip to content

Add entry_at(i) accessor to LoadBackendOptionsMap (#19645)#19645

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
metascroy:export-D105100370
May 19, 2026
Merged

Add entry_at(i) accessor to LoadBackendOptionsMap (#19645)#19645
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
metascroy:export-D105100370

Conversation

@metascroy
Copy link
Copy Markdown
Contributor

@metascroy metascroy commented May 18, 2026

Summary:

LoadBackendOptionsMap exposed get_options(backend_id), has_options(backend_id),
and size() but no way to enumerate the entries. That makes deep-copy,
debugging/pretty-printing, and any other operation that wants to iterate
over the configured backends impossible from outside the class.

Add a public EntryView struct ({backend_id, options}) plus an entry_at(i)
accessor returning a non-owning view at the given index. Header-only,
additive; existing callers are unaffected.

Reviewed By: shoumikhin

Differential Revision: D105100370

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 18, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19645

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit e9b5d80 with merge base 30c9a26 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 18, 2026

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105100370.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 18, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

LoadBackendOptionsMap exposed get_options(backend_id), has_options(backend_id),
and size() but no way to enumerate the entries. That makes deep-copy,
debugging/pretty-printing, and any other operation that wants to iterate
over the configured backends impossible from outside the class.

Add a public EntryView struct ({backend_id, options}) plus an entry_at(i)
accessor returning a non-owning view at the given index. Header-only,
additive; existing callers are unaffected.

Reviewed By: shoumikhin

Differential Revision: D105100370
@meta-codesync meta-codesync Bot changed the title Add entry_at(i) accessor to LoadBackendOptionsMap Add entry_at(i) accessor to LoadBackendOptionsMap (#19645) May 18, 2026
@metascroy metascroy force-pushed the export-D105100370 branch from cbec41c to e9b5d80 Compare May 18, 2026 18:32
@meta-codesync meta-codesync Bot merged commit 12c25cf into pytorch:main May 19, 2026
176 of 178 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants