Skip to content

Bump PyTorch pins to 2.12#19643

Open
JacobSzwejbka wants to merge 7 commits into
mainfrom
pytorch12
Open

Bump PyTorch pins to 2.12#19643
JacobSzwejbka wants to merge 7 commits into
mainfrom
pytorch12

Conversation

@JacobSzwejbka
Copy link
Copy Markdown
Contributor

@JacobSzwejbka JacobSzwejbka commented May 18, 2026

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 18, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19643

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 27 Pending, 1 Unclassified Failure

As of commit d372e0b with merge base 2a0a2f8 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • Check Labels / Check labels (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    RuntimeError: GraphQL query

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 18, 2026
@github-actions github-actions Bot added the module: arm Issues related to arm backend label May 19, 2026
@JacobSzwejbka
Copy link
Copy Markdown
Contributor Author

ARM TOSA failure context for the FoldAndAnnotateQParamsPass change:

The upstream PyTorch change that exposed this is pytorch/pytorch@d8253fa (Add dtype mismatch validation for mm/bmm in meta registrations, pytorch/pytorch#173459). That commit added a dtype check in common_meta_baddbmm_bmm:

torch._check(
    batch1.dtype == batch2.dtype,
    lambda: f"expected scalar type {batch1.dtype} but found {batch2.dtype}",
)

release/2.11 does not have this check; release/2.12 does, which is why the pin bump started failing ARM INT TOSA tests. Note: this was later reverted on PyTorch main by pytorch/pytorch@3208959, but the release/2.12 branch currently still contains the stricter meta check.

The ExecuTorch failure is in an intermediate graph state, not the final lowered TOSA graph. FoldAndAnnotateQParamsPass folds dq -> aten op -> q by removing the explicit q/dq nodes and storing their quantization params in node.meta["input_qparams"] / node.meta["output_qparams"]. Immediately after that fold, before later ARM passes insert rescales / rewrite bmm to TOSA MATMUL, the graph can temporarily contain quantized aten.bmm metadata. Retrying PyTorch's stricter fake aten.bmm kernel on that transient form now raises errors like:

FoldAndAnnotateQParamsPass: expected scalar type torch.float32 but found torch.int32

The ARM patch only special-cases quantized aten.bmm during FoldAndAnnotateQParamsPass metadata refresh. It preserves the existing output shape metadata and sets the fake output dtype from the folded output qparams, avoiding PyTorch's stricter fake bmm validation on the transient graph. The existing later ARM passes still own the actual rescale and TOSA MATMUL lowering path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant