gh-152762: Fix zipfile.Path.is_symlink() raising KeyError for missing entries#152924
Open
UditDewan wants to merge 1 commit into
Open
gh-152762: Fix zipfile.Path.is_symlink() raising KeyError for missing entries#152924UditDewan wants to merge 1 commit into
UditDewan wants to merge 1 commit into
Conversation
…issing entries Treat entries not present in the archive (including the archive root and implied directories) as non-symlinks, matching the boolean-predicate behavior of exists(), is_file(), and is_dir(), as well as pathlib.Path.is_symlink() on a missing filesystem path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zipfile.Path.is_symlink()calledZipFile.getinfo()unguarded, so it raisedKeyErrorfor any path not present in the archive:The same
KeyErrorwas raised for the archive root (zipfile.Path(zf)) and for implied directories, since neither has aZipInfoentry backing it.This change catches the
KeyErrorfromgetinfo()and returnsFalse, sois_symlink()behaves like the neighboring predicates (exists(),is_file(),is_dir()) and likepathlib.Path.is_symlink()on a missing filesystem path. Existing symlink entries are unaffected.Added a test covering the missing-entry, root, and implied-directory cases (all raise
KeyErrorwithout the fix), and a NEWS entry.