gh-144774: Add critical section in BaseException.__setstate__

Lib/test/test_exceptions.py

@@ -1954,6 +1954,24 @@ def test_exec_set_nomemory_hang(self):
         self.assertGreater(len(output), 0)  # At minimum, should not hang
         self.assertIn(b"MemoryError", output)
 
+    def test_data_race(self):
+        from threading import Thread
+        import copy
+
+        E = Exception()
+
+        def func():
+            for i in range(100):
+                setattr(E, 'x', i)
+                copy.copy(E)
+
+        threads = [Thread(target=func) for _ in range(4)]
+
+        for t in threads:
+            t.start()
+
+        for t in threads:
+            t.join()
 
 class NameErrorTests(unittest.TestCase):
     def test_name_error_has_name(self):

Objects/exceptions.c

@@ -225,15 +225,15 @@ BaseException___reduce___impl(PyBaseExceptionObject *self)
  */
 
 /*[clinic input]
-@critical_section
+@critical_section self state
 BaseException.__setstate__
     state: object
     /
 [clinic start generated code]*/
 
 static PyObject *
 BaseException___setstate___impl(PyBaseExceptionObject *self, PyObject *state)
-/*[clinic end generated code: output=f3834889950453ab input=5524b61cfe9b9856]*/
+/*[clinic end generated code: output=f3834889950453ab input=2ddc941f42fc5bf6]*/
 {
     PyObject *d_key, *d_value;
     Py_ssize_t i = 0;