gh-148292: Update ssl._SSLSocket for OpenSSL 4#149102
Conversation
The _SSLSocket object now remembers if it gets an EOF error. In this case, read(), sendfile() and write() method calls fail with SSLEOFError without calling the underlying OpenSSL function.
* Add more tests. * Move set_eof_error() calls.
Documentation build overview
|
| @@ -0,0 +1,7 @@ | |||
| :mod:`ssl`: Update :class:`ssl.SSLSocket` for OpenSSL 4. The class now | |||
| remembers if it gets a :exc:`ssl.SSLEOFError`. In this case, following | |||
| :meth:`~ssl.SSLSocket.read`, :meth:`!sendfile`, :meth:`~ssl.SSLSocket.write`, | |||
There was a problem hiding this comment.
:meth:~ssl.SSLSocket.sendfile ?
There was a problem hiding this comment.
Using :meth:~ssl.SSLSocket.sendfile makes the documentation fails to build. It doesn't work since SSLSocket.sendfile() has no anchor at https://docs.python.org/dev/library/ssl.html#ssl.SSLSocket, but SSLSocket.sendfile() method is documented
Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
@gpshead: Please review the updated PR. Note: Before, I didn't want to use |
Co-authored-by: Victor Stinner <vstinner@python.org>
|
@picnixz: Would you mind to review this change? It would be nice to have OpenSSL 4 support in Python 3.15 beta1 (feature freeze is next Tuesday). |
2 participants
The _SSLSocket object now remembers if it gets an EOF error. In this case, read(), sendfile(), write() and do_handshake() method calls fail with SSLEOFError without calling the underlying OpenSSL function.