Skip to content

Improve tests for the PyUnicodeWriter C API - #146157

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:test-capi-PyUnicodeWriter
Mar 19, 2026
Merged

Improve tests for the PyUnicodeWriter C API#146157
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:test-capi-PyUnicodeWriter

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 19, 2026

Copy link
Copy Markdown
Member

Add tests for corner cases: NULL pointers and out of range values.

@serhiy-storchaka
Improve tests for the PyUnicodeWriter C API
fbe07ae 
Add tests for corner cases: NULL pointers and out of range values.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.14 bugs and security fixes labels Mar 19, 2026
vstinner
vstinner approved these changes Mar 19, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Lib/test/test_capi/test_unicode.py Outdated
@serhiy-storchaka @vstinner
Update Lib/test/test_capi/test_unicode.py
8f04b12 
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka
serhiy-storchaka merged commit ab47892 into python:main Mar 19, 2026
48 checks passed
@miss-islington-app

miss-islington-app Bot commented Mar 19, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the test-capi-PyUnicodeWriter branch March 19, 2026 17:15
@miss-islington-app

miss-islington-app Bot commented Mar 19, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ab47892c32e6361f2180e7d86682650f0850c1c4 3.14

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 19, 2026
@serhiy-storchaka
[3.14] Improve tests for the PyUnicodeWriter C API (pythonGH-146157)
d38aa7f 
Add tests for corner cases: NULL pointers and out of range values.
(cherry picked from commit ab47892)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Mar 19, 2026

Copy link
Copy Markdown

GH-146180 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 19, 2026
serhiy-storchaka added a commit that referenced this pull request Mar 20, 2026
@serhiy-storchaka
[3.14] Improve tests for the PyUnicodeWriter C API (GH-146157) (GH-14…
2105187 
…6180)

Add tests for corner cases: NULL pointers and out of range values.
(cherry picked from commit ab47892)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@serhiy-storchaka @ljfp
Improve tests for the PyUnicodeWriter C API (pythonGH-146157)
a245aff 
Add tests for corner cases: NULL pointers and out of range values.
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @vstinner