Keep duration microseconds exact for large values - #1003
Open
gyanu2507 wants to merge 1 commit into
Open
Conversation
Duration rebuilt _microseconds from total_seconds(), a float, so counts like 8999999999999999 rounded to 999998 instead of 999999. Split from timedelta's integer fields instead. Fixes python-pendulum#332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Durationrebuilt_microsecondsfromtotal_seconds(), which is a float, so a value like8999999999999999came back as999998instead of999999(whatdatetime.timedeltareturns). The constructor now splits days/seconds/microseconds from timedelta's integer fields.Fixes #332