chore: improve cmd2 maintenance path#1669
Open
lphuc2250gma wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1669 +/- ##
==========================================
- Coverage 99.53% 99.53% -0.01%
==========================================
Files 22 22
Lines 4928 4903 -25
==========================================
- Hits 4905 4880 -25
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
requested changes
May 25, 2026
| def __init__( | ||
| self, | ||
| inner_stream: Union[TextIO, "StdSim"], | ||
| inner_stream: TextIO | "StdSim", |
Member
There was a problem hiding this comment.
For the upcoming cmd2 4.0.0 release we support Python versions 3.11 or newer.
Using the | operator with a forward-declaration string type works with Python 3.14+, but does not work with older versions of Python, hence the Union is still required for forward declaration types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Notes: