fix: support platform-specific test runtime environment variables#2941
Open
ychampion wants to merge 1 commit into
Open
fix: support platform-specific test runtime environment variables#2941ychampion wants to merge 1 commit into
ychampion wants to merge 1 commit into
Conversation
Let the shared option reader apply Android and iOS environment overrides, matching the documented configuration precedence. Constraint: Preserve existing global, TOML, and override behavior for test-runtime. Rejected: Add Android/iOS-specific lookup code | OptionsReader already implements platform environment precedence. Confidence: high Scope-risk: narrow Directive: Keep test-runtime on the shared option cascade when adding future platforms. Tested: Focused red/green regression; 824 unit tests; prek all hooks; pylint 10.00/10; diff check. Not-tested: Android and iOS device integration runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-runtimeWhy
The documentation exposes
CIBW_TEST_RUNTIME_ANDROIDandCIBW_TEST_RUNTIME_IOS, buttest-runtimeexplicitly disabled platform environment variables in the option reader. As a result, both variables were ignored.Closes #2936.
Validation
uv run pytest unit_test/options_test.py -q(99 passed, 3 existing xfails)uv run pytest unit_test -q(824 passed, 69 skipped, 3 existing xfails)uvx prek -auvx nox -s pylint(10.00/10)git diff --check