Triggers: Re-expose radius - #254
Merged
Merged
Conversation
Contributor
Author
|
Jeez, it's messed up again... first commit is empty -_- |
Raffson
force-pushed
the
quad-point-triggers
branch
from
August 22, 2022 19:33
5624db5 to
e009f5c
Compare
Contributor
Author
|
@DanAlbert Ok this ought to be it, recommend squashing the following commits: The first two should cancel each other out, leaving you with changes from 'Add test_point_in_poly for mapping.Polygon'. |
The miz includes a radius for all trigger zone types.
Raffson
force-pushed
the
quad-point-triggers
branch
from
August 24, 2022 20:02
e009f5c to
73ab5c7
Compare
Contributor
Author
|
Test has been extracted, this goes to my next PR cause after expanding it some more I ran into some problems with the algorithm for 'point_in_poly'. |
rp-
pushed a commit
that referenced
this pull request
Jun 11, 2026
QuadPoint forwarded args to the parent positionally, so an explicit heading landed in the parent's radius slot (added by PR #254) and link_unit_id was lost. Forward by keyword and pass radius=0, the DCS-canonical value for quad zones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent push/merge in last PR caused some troubles...