Conversation
- Introduced Directory.Build.props and Directory.Packages.props for shared MSBuild properties and centralized NuGet package versions. - Updated various project files to remove specific properties and use centralized versions. - Enhanced GitHub workflows for code generation and pull requests. - Refactored launch configurations and tasks for better organization. Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR centralizes shared build configuration and NuGet package versioning across the solution, and updates editor/CI configuration to align with the new centralized setup.
Changes:
- Added
Directory.Build.propsfor shared MSBuild properties (TFM, analyzers, warnings-as-errors, artifacts path, etc.). - Added
Directory.Packages.propsto centrally manage NuGet package versions and removed per-projectVersionattributes. - Updated VS Code config and GitHub workflows to reflect the new artifacts/output and codegen concurrency behavior.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Tests.csproj | Removes per-project build settings and inlines; relies on centralized properties and CPM package versions. |
| Tests/GlobalUsings.cs | Removes now-redundant System global usings (covered by implicit usings). |
| Library/LogOptions.cs | Removes redundant System.Threading using (covered by implicit usings). |
| Library/Library.csproj | Removes duplicated analyzer/nullable/TFM settings and switches to CPM package references. |
| Library/GlobalUsings.cs | Removes redundant System global using. |
| Directory.Packages.props | Introduces centralized package versions for the solution. |
| Directory.Build.props | Introduces centralized MSBuild properties shared by all projects. |
| Console/GlobalUsings.cs | Removes redundant System* global usings (covered by implicit usings). |
| Console/Console.csproj | Removes duplicated properties and switches to CPM package references. |
| CodeGen/GlobalUsings.cs | Removes redundant System* global usings (covered by implicit usings). |
| CodeGen/CodeGen.csproj | Removes duplicated properties and switches to CPM package references; normalizes project file header. |
| CodeGen/CodeGen.cs | Updates the generated timestamp constant. |
| Benchmarks/GlobalUsings.cs | Removes redundant System global using. |
| Benchmarks/Benchmarks.csproj | Removes duplicated properties and switches to CPM package reference. |
| AGENTS.md | Documents the new centralized build/package configuration approach. |
| .vscode/tasks.json | Adds a benchmark task aligned with the .artifacts layout. |
| .vscode/launch.json | Updates debug launch paths to the .artifacts output layout. |
| .github/workflows/run-periodic-codegen-pull-request.yml | Adjusts concurrency grouping to target main/codegen consistently. |
| .github/workflows/run-periodic-codegen-app-pull-request.yml | Adjusts concurrency grouping to target main/codegen consistently. |
| .github/copilot-instructions.md | Documents the new centralized MSBuild and CPM setup. |
ptr727
added a commit
that referenced
this pull request
Apr 14, 2026
…#46) - Introduced Directory.Build.props and Directory.Packages.props for shared MSBuild properties and centralized NuGet package versions. - Updated various project files to remove specific properties and use centralized versions. - Enhanced GitHub workflows for code generation and pull requests. - Refactored launch configurations and tasks for better organization. Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pieter Viljoen ptr727@users.noreply.github.com