Skip to content

Add central project configuration and update package references - #45

Merged
ptr727 merged 1 commit into
developfrom
dirprops
Apr 13, 2026
Merged

Add central project configuration and update package references#45
ptr727 merged 1 commit into
developfrom
dirprops

Conversation

@ptr727

@ptr727 ptr727 commented Apr 13, 2026

Copy link
Copy Markdown
Owner
  • Introduced Directory.Build.props and Directory.Packages.props for shared MSBuild properties and centralized NuGet package versions.
  • Updated various project files to remove specific properties and use centralized versions.
  • Enhanced GitHub workflows for code generation and pull requests.
  • Refactored launch configurations and tasks for better organization.

Signed-off-by: Pieter Viljoen ptr727@users.noreply.github.com

- Introduced Directory.Build.props and Directory.Packages.props for shared MSBuild properties and centralized NuGet package versions.
- Updated various project files to remove specific properties and use centralized versions.
- Enhanced GitHub workflows for code generation and pull requests.
- Refactored launch configurations and tasks for better organization.

Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 13, 2026 22:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes shared build configuration and NuGet package versioning across the solution, and updates editor/CI configuration to align with the new centralized setup.

Changes:

  • Added Directory.Build.props for shared MSBuild properties (TFM, analyzers, warnings-as-errors, artifacts path, etc.).
  • Added Directory.Packages.props to centrally manage NuGet package versions and removed per-project Version attributes.
  • Updated VS Code config and GitHub workflows to reflect the new artifacts/output and codegen concurrency behavior.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Tests/Tests.csproj Removes per-project build settings and inlines; relies on centralized properties and CPM package versions.
Tests/GlobalUsings.cs Removes now-redundant System global usings (covered by implicit usings).
Library/LogOptions.cs Removes redundant System.Threading using (covered by implicit usings).
Library/Library.csproj Removes duplicated analyzer/nullable/TFM settings and switches to CPM package references.
Library/GlobalUsings.cs Removes redundant System global using.
Directory.Packages.props Introduces centralized package versions for the solution.
Directory.Build.props Introduces centralized MSBuild properties shared by all projects.
Console/GlobalUsings.cs Removes redundant System* global usings (covered by implicit usings).
Console/Console.csproj Removes duplicated properties and switches to CPM package references.
CodeGen/GlobalUsings.cs Removes redundant System* global usings (covered by implicit usings).
CodeGen/CodeGen.csproj Removes duplicated properties and switches to CPM package references; normalizes project file header.
CodeGen/CodeGen.cs Updates the generated timestamp constant.
Benchmarks/GlobalUsings.cs Removes redundant System global using.
Benchmarks/Benchmarks.csproj Removes duplicated properties and switches to CPM package reference.
AGENTS.md Documents the new centralized build/package configuration approach.
.vscode/tasks.json Adds a benchmark task aligned with the .artifacts layout.
.vscode/launch.json Updates debug launch paths to the .artifacts output layout.
.github/workflows/run-periodic-codegen-pull-request.yml Adjusts concurrency grouping to target main/codegen consistently.
.github/workflows/run-periodic-codegen-app-pull-request.yml Adjusts concurrency grouping to target main/codegen consistently.
.github/copilot-instructions.md Documents the new centralized MSBuild and CPM setup.

@ptr727
ptr727 merged commit 3a5faeb into develop Apr 13, 2026
24 checks passed
@ptr727
ptr727 deleted the dirprops branch April 13, 2026 23:10
ptr727 added a commit that referenced this pull request Apr 14, 2026
…#46)

- Introduced Directory.Build.props and Directory.Packages.props for
shared MSBuild properties and centralized NuGet package versions.
- Updated various project files to remove specific properties and use
centralized versions.
- Enhanced GitHub workflows for code generation and pull requests.
- Refactored launch configurations and tasks for better organization.

Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>

Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>

---------

Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants