feat(observability): improvements - #63
Merged
Merged
Conversation
…nd fetch triggers Metrics were tagged with the full QueryKey, which embeds per-entity args and produces unbounded cardinality in production; retry counts and cancellation status were documented but never implemented. Splits metrics onto a low-cardinality query.name/mutation.name tag (full key stays on spans/logs, with an opt-in IncludeQueryKeyInMetrics escape hatch), adds retry-attempt counters, cancellation status, cache entry/eviction metrics, and a trigger tag distinguishing manual/invalidate/interval/stale/prefetch fetches. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 94.98% 94.27% -0.72%
==========================================
Files 21 22 +1
Lines 877 995 +118
Branches 150 179 +29
==========================================
+ Hits 833 938 +105
Misses 21 21
- Partials 23 36 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codecov flagged patch coverage at 88.0% (target 90%). Cross-referenced merged cobertura reports against the PR diff and added targeted tests for the untested branches: mutation/query retry-count telemetry on the failure path, QueryObserver/Query.MetricName resolution (explicit Name, key-part fallback, empty-key fallback), and the FetchTrigger.ToTagValue default arm. Patch coverage is now 92.57% locally against the same diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.