2.4x improvement in Cluster aggregation performance - #692
Merged
Conversation
jdmarshall
force-pushed
the
clusterLabels
branch
from
July 29, 2025 00:14
623ecd2 to
571f8e1
Compare
jdmarshall
changed the title
Contributor
Author
|
This should fix #628 A lot of the gain here is that |
Contributor
Author
|
Node 20 did not support Iterator.filter?? I'm surprised it's still in LTS. Working on it. |
jdmarshall
changed the title
This was referenced Jul 29, 2025
jdmarshall
force-pushed
the
clusterLabels
branch
2 times, most recently
from
November 3, 2025 23:48
b3916cd to
c37ed35
Compare
Collaborator
|
@jdmarshall sorry, missed this. Mind resolving the conflict? Your new benchmark runner has also landed 🙂 |
This also fixes issue with prettier.
…sult." This reverts commit ab12221.
This reverts most of commit 9251668. Except for some of the tests.
This has to wrestle with the problem of lack of fore-knowledge of the canonical set of labels. We achieve this by assuming 6 labels to begin with, first filling in the empties as we discover new ones, and tnen expanding the columns by ⌈25%⌉ if they don't, and re-keying the entire table (by concatenating extra ||'s onto the end).. Before and after: ✓ cluster ➭ aggregate() is 6.088% faster. ✓ cluster ➭ aggregate() is 149.4% faster.
jdmarshall
force-pushed
the
clusterLabels
branch
from
November 28, 2025 00:40
c37ed35 to
104275f
Compare
Collaborator
I'm not allowed to push to your fork to resolve the conflict 😅 |
Contributor
Author
|
fixed. For now |
Contributor
Author
|
@SimenB can we land this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a similar strategy to LabelMap for stats coalescing for cluster.js
This has to wrestle with the problem of lack of fore-knowledge of the
canonical set of labels. We achieve this by assuming 6 labels to
begin with, first filling in the empties as we discover new ones, and
tnen expanding the columns by ⌈25%⌉ if they don't, and re-keying the
entire table (by concatenating extra ||'s onto the end)..