Skip to content

Fix/migrate to go podman image#766

Open
raharper wants to merge 4 commits into
project-stacker:mainfrom
raharper:fix/migrate-to-go-podman-image
Open

Fix/migrate to go podman image#766
raharper wants to merge 4 commits into
project-stacker:mainfrom
raharper:fix/migrate-to-go-podman-image

Conversation

@raharper

Copy link
Copy Markdown
Contributor

What type of PR is this?

cleanup

Which issue does this PR fix:

n/a

What does this PR do / Why do we need it:

Migrate from containers/image/v5 (now deprecated) to the new mono-repo
https://github.com/podman-container-tools/container-libs

Bump incus/v6 -> incus/v7

Bump go 1.25.10 -> 1.25.11

Bump x/crypto and x/net to fix CVEs

Testing done on this change:

build and make test

Automation added to e2e:

none

Will this break upgrades or downgrades?

no

Does this PR introduce any user-facing change?:

no


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@raharper

Copy link
Copy Markdown
Contributor Author

Chasing this odd error in the overlay test:

# Error: couldn't import base layer base: initializing source 
docker://gcr.io/distroless/base:latest: 
loading registries configuration: 
loading registries configuration "/etc/containers/registries.conf":
registries.conf must be in v2 format but is in v1

I cannot recreate this on a local 24.04 x86_64 vm, nor on a 24.04 arm64 vm -- currently seeing if the ubuntu 24.04 runner has some of these things baked into the image that aren't in normal/vanilla 24.04 environments.

@raharper

Copy link
Copy Markdown
Contributor Author

Chasing this odd error in the overlay test:

# Error: couldn't import base layer base: initializing source 
docker://gcr.io/distroless/base:latest: 
loading registries configuration: 
loading registries configuration "/etc/containers/registries.conf":
registries.conf must be in v2 format but is in v1

I cannot recreate this on a local 24.04 x86_64 vm, nor on a 24.04 arm64 vm -- currently seeing if the ubuntu 24.04 runner has some of these things baked into the image that aren't in normal/vanilla 24.04 environments.

Yeah, I can reproduce this by placing a v1 registries.conf in $HOME/.config/containers/registries.conf

[registries.search]
registries = ['docker.io', 'quay.io']

Testing out a change to overlay.bats to move it out of the way at start and restore at the end.

Not super happy about that w.r.t running tests locally could mess with the system.

@raharper raharper force-pushed the fix/migrate-to-go-podman-image branch from f5d8593 to 1578657 Compare June 25, 2026 22:10
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.83%. Comparing base (588ebcf) to head (aa5a2bb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   54.86%   54.83%   -0.04%     
==========================================
  Files          55       55              
  Lines        5909     5909              
==========================================
- Hits         3242     3240       -2     
- Misses       2094     2096       +2     
  Partials      573      573              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raharper

Copy link
Copy Markdown
Contributor Author

Chasing this odd error in the overlay test:

# Error: couldn't import base layer base: initializing source 
docker://gcr.io/distroless/base:latest: 
loading registries configuration: 
loading registries configuration "/etc/containers/registries.conf":
registries.conf must be in v2 format but is in v1

I cannot recreate this on a local 24.04 x86_64 vm, nor on a 24.04 arm64 vm -- currently seeing if the ubuntu 24.04 runner has some of these things baked into the image that aren't in normal/vanilla 24.04 environments.

Yeah, I can reproduce this by placing a v1 registries.conf in $HOME/.config/containers/registries.conf

[registries.search]
registries = ['docker.io', 'quay.io']

Testing out a change to overlay.bats to move it out of the way at start and restore at the end.

Not super happy about that w.r.t running tests locally could mess with the system.

Current "fix" here is for github runners to move it out of the way.

stacker using podman containers lib means that we should consume those configs if present; just like we do for things like containers auth.json;

Not sure if we should extend stacker check or just let it fail like it did and user can sort out updating their registries.conf file.

raharper and others added 4 commits June 25, 2026 17:58
Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <rharper@woxford.com>
@raharper raharper force-pushed the fix/migrate-to-go-podman-image branch from 1578657 to aa5a2bb Compare June 25, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant