Library version number parsing does not ignore comments

[processing-bot]

Created by: prisonerjohn

Description

Processing 4 Contribution Manager appears to include # comments in the property values, which causes number parsing for version value to fail.

It looks like maybe this was already reported in #553 but it was closed for inactivity.

Expected Behavior

If the properties file includes a line like:

version = 12  # This must be parsable as an int

The parser should ignore the # and everything after it when retrieving the value.

Processing 3.5.4 appears to do this correctly.

Current Behavior

Processing 4.0.1 includes comments in the library prettyVersion and complains about "The version number for “XXX” is not a number."

Steps to Reproduce

1. Open the Processing Contribution Manager
2. Try to download the library nub or websockets

Your Environment

• Processing version: 4.0.1
• Operating System and OS version: Windows 11
• Other information:

Possible Causes / Solutions

[processing-bot]

Created by: benfry

Ah, that makes more sense than the report in #553. Should be straightforward to fix.

[processing-bot]

Created by: benfry

Fixed for 4.0.2. The problem was that in-line comments (versus comments starting at the beginning of a line) were disabled so that it was possible to parse hex colors from settings files. (Otherwise, a hex color just looks like a comment.) Split the two cases and we should be all set.

[processing-bot]

Created by: github-actions[bot]

This issue has been automatically locked. To avoid confusion with reports that have already been resolved, closed issues are automatically locked 30 days after the last comment. Please open a new issue for related bugs.