feat: use Prisma Composer for deployments - #52
Open
AmanVarshney01 wants to merge 15 commits into
Open
Conversation
Replace legacy Compute config generation with default Composer graphs for supported templates. Support npm, pnpm, Yarn, and Bun, including Composer-managed Prisma Postgres deployment and migration and seed handoff. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Summary by CodeRabbit
WalkthroughThe create flow now uses Prisma Composer for deployment. It collects Composer context, scaffolds Composer application graph files, configures Composer dependencies, provisions or binds databases, and runs Composer deploy scripts. Prisma migrations and seeding run after Composer provisions Prisma Postgres. Template output, package scripts, telemetry, and documentation now refer to Composer and remove Prisma Compute paths. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
PR preview published
|
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 154: Update the Composer deployment documentation sentence in README.md
to stop recommending the retired prisma-compute skill; recommend the Prisma
Composer skill only if the add-on installs one, otherwise remove the sentence
entirely.
- Line 100: Update README.md lines 100-100 to state that Composer files are
generated only for supported Composer-enabled templates using npm, pnpm, Yarn,
or Bun. In templates/create/astro/README.md.hbs lines 24-26, wrap the Composer
file list in the existing composer conditional so it is omitted for Deno
scaffolding.
In `@src/commands/create.ts`:
- Around line 61-63: Clarify the distinct roles of the Composer context fields
in the options type near useComposerPostgres: rename composerContext to
composerScaffoldContext while keeping composerDeployContext unchanged, and
update all references to the renamed field so scaffolding and deployment
behavior remain separate.
- Around line 502-538: Update the post-deployment database wiring in the
successful branch of the composer deployment flow so failures from
resolveComposerPostgresDatabaseUrl do not reach the outer catch or return stage
composer_deploy failure. Catch URL resolution errors, record a warning in
prismaResult.warningSection, add the package-manager-specific db:migrate and
db:seed commands to prismaResult.nextSteps, and continue to the existing deploy
next-step handling; preserve executePrismaMigrationAndSeed behavior when URL
resolution succeeds.
In `@src/constants/dependencies.ts`:
- Around line 85-99: Update the root Composer dependency target in the
composerTemplates block to include dotenv when template is "turborepo", ensuring
it is declared in the repository root package.json dependencies while preserving
existing dependencies and target-specific configuration.
In `@src/tasks/deploy-with-composer.ts`:
- Around line 106-112: Update the error-detail selection in the deploy result
handling around getErrorMessage so a failed parsed CLI response with neither
error.summary nor error.message uses a meaningful fallback instead of undefined.
Preserve the existing stderr fallback for non-parsed or invalid-output failures.
- Line 17: Update the PRISMA_PLATFORM_CLI constant to use an exact tested
`@prisma/cli` version instead of the latest tag, preserving the JSON contract
expected by the database list and connection create parsers.
In `@src/tasks/setup-prisma.ts`:
- Around line 753-768: Update executePrismaMigrationAndSeed to accept the
caller’s didGenerateClient state and forward it unchanged to
migrateAndSeedIfRequested instead of hardcoding true; update its callers,
including executePrismaSetupContext, to pass the actual client-generation result
so migration and seeding are skipped with the intended warning when generation
failed.
In `@src/templates/render-create-template.ts`:
- Around line 94-113: Replace the text-based matching and insertion in
mergePnpmComposerOverrides with YAML parsing and serialization, using the
project’s existing YAML library if available. Read and update only the overrides
mapping, preserving other sections such as catalog and packageExtensions, and
merge package names regardless of quoting style so existing keys are not
duplicated. Remove the regex-based presence check and line-splicing approach
while retaining the function’s current output behavior for missing overrides.
- Around line 101-103: Update the missingOverrides mapping in
render-create-template to serialize the version value as a quoted YAML string,
matching the existing JSON.stringify treatment of packageName. Preserve the
generated key and version content while ensuring values such as 4.0 remain
strings.
In `@templates/create/hono/module.ts.hbs`:
- Around line 5-17: Add dotenv to the Composer dependency target’s dependency
list or map, alongside the existing dotenv entry, so Composer installations
include it when composerPostgres is disabled. Update the Composer dependency
configuration rather than changing the module template import.
In `@templates/create/next/README.md.hbs`:
- Around line 22-24: Make Composer files conditional in all four README
templates: wrap the listed Composer entries in {{`#if` composer}} blocks in
templates/create/next/README.md.hbs (22-24), templates/create/nuxt/README.md.hbs
(24-26), templates/create/tanstack-start/README.md.hbs (23-25), and
templates/create/turborepo/README.md.hbs (31-33). In the Turborepo template,
also correct the service.ts path as specified by the review.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d99abb9f-c7d7-4895-bbda-f236d472b84a
📒 Files selected for processing (64)
README.mdsrc/commands/create.tssrc/constants/dependencies.tssrc/tasks/deploy-to-compute.tssrc/tasks/deploy-with-composer.tssrc/tasks/install.tssrc/tasks/setup-addons.tssrc/tasks/setup-prisma.tssrc/telemetry/create.tssrc/templates/render-create-template.tssrc/types.tstemplates/create/astro/README.md.hbstemplates/create/astro/module.ts.hbstemplates/create/astro/prisma-composer.config.ts.hbstemplates/create/astro/prisma.compute.ts.hbstemplates/create/astro/service.ts.hbstemplates/create/astro/src/lib/prisma.ts.hbstemplates/create/elysia/README.md.hbstemplates/create/elysia/module.ts.hbstemplates/create/elysia/package.json.hbstemplates/create/elysia/prisma-composer.config.ts.hbstemplates/create/elysia/prisma.compute.ts.hbstemplates/create/elysia/service.ts.hbstemplates/create/elysia/src/lib/prisma.ts.hbstemplates/create/hono/README.md.hbstemplates/create/hono/module.ts.hbstemplates/create/hono/package.json.hbstemplates/create/hono/prisma-composer.config.ts.hbstemplates/create/hono/prisma.compute.ts.hbstemplates/create/hono/service.ts.hbstemplates/create/hono/src/lib/prisma.ts.hbstemplates/create/nest/README.md.hbstemplates/create/nest/module.ts.hbstemplates/create/nest/package.json.hbstemplates/create/nest/prisma-composer.config.ts.hbstemplates/create/nest/prisma.compute.ts.hbstemplates/create/nest/src/lib/prisma.ts.hbstemplates/create/nest/src/service.ts.hbstemplates/create/next/README.md.hbstemplates/create/next/module.ts.hbstemplates/create/next/prisma-composer.config.ts.hbstemplates/create/next/prisma.compute.ts.hbstemplates/create/next/service.ts.hbstemplates/create/next/src/lib/prisma.ts.hbstemplates/create/nuxt/README.md.hbstemplates/create/nuxt/module.ts.hbstemplates/create/nuxt/prisma-composer.config.ts.hbstemplates/create/nuxt/prisma.compute.ts.hbstemplates/create/nuxt/server/utils/prisma.ts.hbstemplates/create/nuxt/service.ts.hbstemplates/create/svelte/README.md.hbstemplates/create/tanstack-start/README.md.hbstemplates/create/tanstack-start/module.ts.hbstemplates/create/tanstack-start/prisma-composer.config.ts.hbstemplates/create/tanstack-start/prisma.compute.ts.hbstemplates/create/tanstack-start/service.ts.hbstemplates/create/tanstack-start/src/lib/prisma.server.ts.hbstemplates/create/turborepo/README.md.hbstemplates/create/turborepo/apps/api/package.json.hbstemplates/create/turborepo/apps/api/src/index.ts.hbstemplates/create/turborepo/apps/api/src/service.ts.hbstemplates/create/turborepo/module.ts.hbstemplates/create/turborepo/prisma-composer.config.ts.hbstemplates/create/turborepo/prisma.compute.ts.hbs
💤 Files with no reviewable changes (10)
- templates/create/nest/prisma.compute.ts.hbs
- templates/create/hono/prisma.compute.ts.hbs
- templates/create/astro/prisma.compute.ts.hbs
- templates/create/nuxt/prisma.compute.ts.hbs
- templates/create/turborepo/prisma.compute.ts.hbs
- templates/create/next/prisma.compute.ts.hbs
- templates/create/elysia/prisma.compute.ts.hbs
- templates/create/tanstack-start/prisma.compute.ts.hbs
- templates/create/svelte/README.md.hbs
- src/tasks/deploy-to-compute.ts
Generated package scripts already resolve local binaries through the package manager PATH, so emit prisma commands instead of hard-coded node_modules paths. Use bunx with the Bun runtime only for create-prisma internal execution. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Include Svelte in the Composer template matrix, make the starter schema and Prisma Client generation unconditional, and default PostgreSQL projects to Composer-managed Prisma Postgres. Keep migrate and seed tied to deployment while supporting both immediate and delayed deploys across npm, pnpm, Yarn, and Bun. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (7)
templates/create/tanstack-start/README.md.hbs (1)
43-45: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winThe generated READMEs do not document the database change performed by
deploy. WhencomposerPostgresis enabled,getComposerDeployScriptMapappendscomposer:database:setupto thedeployscript. That step migrates and seeds the Composer-managed database. Both READMEs presentdeployas a deployment command only, so a reader cannot tell that it changes the remote schema.
templates/create/tanstack-start/README.md.hbs#L43-L45: add a sentence under thecomposerPostgresbranch stating thatdeployalso migrates and seeds the Composer-managed database.templates/create/turborepo/README.md.hbs#L43-L45: add the same sentence under thecomposerPostgresbranch.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@templates/create/tanstack-start/README.md.hbs` around lines 43 - 45, Update the composerPostgres branch in templates/create/tanstack-start/README.md.hbs lines 43-45 and templates/create/turborepo/README.md.hbs lines 43-45 to state that the deploy command also migrates and seeds the Composer-managed database.src/constants/dependencies.ts (1)
34-44: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick winReuse the exported deployable-template set.
composerTemplatesduplicatesCOMPOSER_DEPLOYABLE_TEMPLATESinsrc/types.ts(Lines 86-96). Both lists are identical today. If a future template is added to only one list, dependency wiring and deploy gating disagree without a type error: the create flow deploys a project that never received@prisma/composer, or it installs Composer packages that are never used.Import the existing set here.
♻️ Proposed refactor
-const composerTemplates = new Set<CreateTemplate>([ - "hono", - "elysia", - "nest", - "next", - "astro", - "nuxt", - "svelte", - "tanstack-start", - "turborepo", -]); +import { COMPOSER_DEPLOYABLE_TEMPLATES } from "../types"; + +const composerTemplates = COMPOSER_DEPLOYABLE_TEMPLATES;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/constants/dependencies.ts` around lines 34 - 44, Remove the duplicated composerTemplates set and import the exported COMPOSER_DEPLOYABLE_TEMPLATES from types.ts instead. Update any references in this file to use the imported set, preserving the existing deployable-template membership.templates/create/tanstack-start/src/routes/index.tsx.hbs (1)
6-30: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winWiden the bootstrap error guard beyond
P2021.The Composer flow deploys the service first and runs
composer:database:setupafterwards. Between those two steps the service is live while the schema does not exist and the database may still be unreachable.isBootstrapQueryErrormatches onlyP2021(table does not exist). A connection error (P1001) or a missing schema (P1010,P1017) propagates and the home route returns a 500 instead of the prepared empty state at Lines 66-70.🐛 Proposed fix
+const BOOTSTRAP_ERROR_CODES = new Set(["P2021", "P1001", "P1010", "P1017"]); + function isBootstrapQueryError(error: unknown): error is { code?: string } { return ( typeof error === "object" && error !== null && "code" in error && - (error as { code?: string }).code === "P2021" + BOOTSTRAP_ERROR_CODES.has((error as { code?: string }).code ?? "") ); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@templates/create/tanstack-start/src/routes/index.tsx.hbs` around lines 6 - 30, Expand isBootstrapQueryError to recognize Prisma bootstrap failures P2021, P1001, P1010, and P1017, while preserving the existing type guard and undefined fallback in listUsers. Allow only these codes to return the prepared empty state; continue propagating all other errors.templates/create/turborepo/apps/api/src/index.ts.hbs (2)
10-20: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winLog Composer database URL resolution errors.
The
catchblock continues without settingDATABASE_URL. Prisma then fails later withDATABASE_URL is required, which hides the Composer configuration error. Log the caught error or rethrow it with context.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@templates/create/turborepo/apps/api/src/index.ts.hbs` around lines 10 - 20, Update the Composer database URL resolution catch block near the conditional composerDatabaseUrl setup to log the caught error or rethrow it with clear Composer configuration context before leaving the block; preserve the existing undefined fallback behavior only if the error is logged.
63-74: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winUse the Composer port before
PORT
service.port()is the authoritative Composer port. IfPORTcontains a different valid value, line 74 binds the server to the wrong port. ResolvecomposerPortbeforeparsedPortin the Composer branch; keepPORTas the local fallback.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@templates/create/turborepo/apps/api/src/index.ts.hbs` around lines 63 - 74, The port selection expression should prioritize the authoritative composerPort over parsedPort when the Composer branch is enabled. Update the fallback order near service.port() so a valid PORT value is used only when composerPort is unavailable, while retaining the existing 3000 default and validation behavior.src/types.ts (1)
62-63: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDocument the removed CLI options.
prismaPostgres,generate,migrateAndSeed, andschemaPresetare no longer CLI options.trpc-clirejects their flags as unknown options. Add migration guidance for these flags toCHANGELOG.mdandREADME.md.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/types.ts` around lines 62 - 63, Document the removal of the prismaPostgres, generate, migrateAndSeed, and schemaPreset CLI options in CHANGELOG.md and README.md, including migration guidance for users whose commands still pass these flags. Do not add them back to the schema near databaseUrl or install; update only the user-facing documentation.templates/create/astro/README.md.hbs (1)
40-46: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winDocument the first Composer Postgres deployment. When
composerPostgresis enabled, the firstdeployprovisions the database and runs the deployment-managed migration and seed flow. The current text callsdeploya later-change action and directs users to rundb:migrateanddb:seedbefore Composer has provisioned a database.
templates/create/astro/README.md.hbs#L40-L46: state that the firstdeployprovisions, migrates, and seeds Prisma Postgres.templates/create/astro/src/pages/index.astro.hbs#L46-L52: conditionally direct Composer Postgres users to rundeployfirst.templates/create/elysia/README.md.hbs#L35-L41: state that the firstdeployprovisions, migrates, and seeds Prisma Postgres.templates/create/hono/README.md.hbs#L35-L41: state that the firstdeployprovisions, migrates, and seeds Prisma Postgres.templates/create/nest/README.md.hbs#L35-L41: state that the firstdeployprovisions, migrates, and seeds Prisma Postgres.templates/create/next/README.md.hbs#L38-L44: state that the firstdeployprovisions, migrates, and seeds Prisma Postgres.templates/create/next/src/app/page.tsx.hbs#L37-L43: conditionally direct Composer Postgres users to rundeployfirst.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@templates/create/astro/README.md.hbs` around lines 40 - 46, Update the Composer Postgres guidance in templates/create/astro/README.md.hbs (lines 40-46), templates/create/elysia/README.md.hbs (lines 35-41), templates/create/hono/README.md.hbs (lines 35-41), templates/create/nest/README.md.hbs (lines 35-41), and templates/create/next/README.md.hbs (lines 38-44) so the first deploy provisions Prisma Postgres and runs the managed migration and seed flow, rather than describing deploy only for later changes. In templates/create/astro/src/pages/index.astro.hbs (lines 46-52) and templates/create/next/src/app/page.tsx.hbs (lines 37-43), conditionally direct composerPostgres users to run deploy first while preserving the existing guidance for other database configurations.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/tasks/deploy-with-composer.ts`:
- Around line 200-205: Update the composer:database:setup command in the deploy
command construction to select the runtime from context.packageManager instead
of hardcoding node, using bun for Bun projects so the setup script remains
executable in both environments.
In `@src/templates/render-create-template.ts`:
- Around line 101-107: Update the overrides handling around
document.get("overrides", true) to replace a scalar node whose value is null
with document.createNode({}) before calling isMap. Preserve the existing error
for non-null, non-mapping overrides and continue using the resulting mapping for
subsequent updates.
In `@src/templates/shared.ts`:
- Around line 52-63: Generated CLI commands fail on Windows because
package-manager shims require a shell. In src/templates/shared.ts:52-63,
preserve the existing helper command generation and ensure its consumers use
shell execution; in templates/shared/setup-composer-postgres.mjs.hbs:25-34,
update runPlatformCli’s spawnSync options to enable shell execution, and in
templates/shared/setup-composer-postgres.mjs.hbs:101-106, make the same change
to runPrisma.
In `@templates/shared/setup-composer-postgres.mjs.hbs`:
- Around line 128-156: Move the existing try/finally cleanup scope to
immediately after the connection is created so missing databaseUrl errors still
remove the temporary connection via runPlatformCli. Update the cleanup branch
around connectionId to emit a warning when the ID is unavailable, clearly
indicating that the temporary connection could not be removed.
- Around line 35-45: Update runPlatformCli to wrap JSON.parse(result.stdout) in
error handling and throw a redacted error using the existing secret-redaction
path when parsing fails. Extend redactSecrets to also detect and redact
credentials embedded in bare database URLs such as
postgres://user:password@host/db, while preserving its existing NAME=value
handling.
- Around line 134-139: Update the migration setup flow around runPrisma so
Composer-managed databases never invoke "migrate dev". Use "migrate deploy" when
committed migrations exist, and replace the no-migrations branch with an
explicit initial-setup path or an actionable error; do not add "db push
--skip-generate" as a general fallback. Keep the subsequent runPrisma(["db",
"seed"], databaseUrl) behavior unchanged.
---
Outside diff comments:
In `@src/constants/dependencies.ts`:
- Around line 34-44: Remove the duplicated composerTemplates set and import the
exported COMPOSER_DEPLOYABLE_TEMPLATES from types.ts instead. Update any
references in this file to use the imported set, preserving the existing
deployable-template membership.
In `@src/types.ts`:
- Around line 62-63: Document the removal of the prismaPostgres, generate,
migrateAndSeed, and schemaPreset CLI options in CHANGELOG.md and README.md,
including migration guidance for users whose commands still pass these flags. Do
not add them back to the schema near databaseUrl or install; update only the
user-facing documentation.
In `@templates/create/astro/README.md.hbs`:
- Around line 40-46: Update the Composer Postgres guidance in
templates/create/astro/README.md.hbs (lines 40-46),
templates/create/elysia/README.md.hbs (lines 35-41),
templates/create/hono/README.md.hbs (lines 35-41),
templates/create/nest/README.md.hbs (lines 35-41), and
templates/create/next/README.md.hbs (lines 38-44) so the first deploy provisions
Prisma Postgres and runs the managed migration and seed flow, rather than
describing deploy only for later changes. In
templates/create/astro/src/pages/index.astro.hbs (lines 46-52) and
templates/create/next/src/app/page.tsx.hbs (lines 37-43), conditionally direct
composerPostgres users to run deploy first while preserving the existing
guidance for other database configurations.
In `@templates/create/tanstack-start/README.md.hbs`:
- Around line 43-45: Update the composerPostgres branch in
templates/create/tanstack-start/README.md.hbs lines 43-45 and
templates/create/turborepo/README.md.hbs lines 43-45 to state that the deploy
command also migrates and seeds the Composer-managed database.
In `@templates/create/tanstack-start/src/routes/index.tsx.hbs`:
- Around line 6-30: Expand isBootstrapQueryError to recognize Prisma bootstrap
failures P2021, P1001, P1010, and P1017, while preserving the existing type
guard and undefined fallback in listUsers. Allow only these codes to return the
prepared empty state; continue propagating all other errors.
In `@templates/create/turborepo/apps/api/src/index.ts.hbs`:
- Around line 10-20: Update the Composer database URL resolution catch block
near the conditional composerDatabaseUrl setup to log the caught error or
rethrow it with clear Composer configuration context before leaving the block;
preserve the existing undefined fallback behavior only if the error is logged.
- Around line 63-74: The port selection expression should prioritize the
authoritative composerPort over parsedPort when the Composer branch is enabled.
Update the fallback order near service.port() so a valid PORT value is used only
when composerPort is unavailable, while retaining the existing 3000 default and
validation behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d53077f9-75a6-4696-8dcf-664950b5f892
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (60)
README.mdpackage.jsonsrc/commands/create.tssrc/constants/dependencies.tssrc/index.tssrc/tasks/deploy-with-composer.tssrc/tasks/setup-prisma.tssrc/telemetry/create.tssrc/templates/render-create-template.tssrc/templates/shared.tssrc/types.tstemplates/create/astro/README.md.hbstemplates/create/astro/prisma/schema.prisma.hbstemplates/create/astro/prisma/seed.ts.hbstemplates/create/astro/src/pages/api/users.ts.hbstemplates/create/astro/src/pages/index.astro.hbstemplates/create/elysia/README.md.hbstemplates/create/elysia/prisma/schema.prisma.hbstemplates/create/elysia/prisma/seed.ts.hbstemplates/create/elysia/src/index.ts.hbstemplates/create/hono/README.md.hbstemplates/create/hono/prisma/schema.prisma.hbstemplates/create/hono/prisma/seed.ts.hbstemplates/create/hono/src/index.ts.hbstemplates/create/nest/README.md.hbstemplates/create/nest/prisma/schema.prisma.hbstemplates/create/nest/prisma/seed.ts.hbstemplates/create/nest/src/app.module.ts.hbstemplates/create/nest/src/users.controller.ts.hbstemplates/create/nest/src/users.service.ts.hbstemplates/create/next/README.md.hbstemplates/create/next/prisma/schema.prisma.hbstemplates/create/next/prisma/seed.ts.hbstemplates/create/next/src/app/page.tsx.hbstemplates/create/nuxt/README.md.hbstemplates/create/nuxt/app/pages/index.vue.hbstemplates/create/nuxt/prisma/schema.prisma.hbstemplates/create/nuxt/prisma/seed.ts.hbstemplates/create/nuxt/server/api/users.get.ts.hbstemplates/create/svelte/README.md.hbstemplates/create/svelte/module.ts.hbstemplates/create/svelte/package.json.hbstemplates/create/svelte/prisma-composer.config.ts.hbstemplates/create/svelte/prisma/schema.prisma.hbstemplates/create/svelte/prisma/seed.ts.hbstemplates/create/svelte/service.ts.hbstemplates/create/svelte/src/lib/server/prisma.ts.hbstemplates/create/svelte/src/routes/+page.server.ts.hbstemplates/create/svelte/src/routes/+page.svelte.hbstemplates/create/svelte/svelte.config.jstemplates/create/svelte/svelte.config.js.hbstemplates/create/tanstack-start/README.md.hbstemplates/create/tanstack-start/prisma/schema.prisma.hbstemplates/create/tanstack-start/prisma/seed.ts.hbstemplates/create/tanstack-start/src/routes/index.tsx.hbstemplates/create/turborepo/README.md.hbstemplates/create/turborepo/apps/api/src/index.ts.hbstemplates/create/turborepo/packages/db/prisma/schema.prisma.hbstemplates/create/turborepo/packages/db/prisma/seed.ts.hbstemplates/shared/setup-composer-postgres.mjs.hbs
💤 Files with no reviewable changes (24)
- templates/create/svelte/svelte.config.js
- templates/create/nest/src/users.controller.ts.hbs
- templates/create/tanstack-start/prisma/schema.prisma.hbs
- templates/create/svelte/src/routes/+page.svelte.hbs
- templates/create/nest/prisma/seed.ts.hbs
- templates/create/turborepo/packages/db/prisma/seed.ts.hbs
- templates/create/hono/prisma/schema.prisma.hbs
- templates/create/hono/prisma/seed.ts.hbs
- templates/create/svelte/prisma/seed.ts.hbs
- templates/create/astro/prisma/schema.prisma.hbs
- templates/create/next/prisma/seed.ts.hbs
- templates/create/nuxt/server/api/users.get.ts.hbs
- templates/create/svelte/prisma/schema.prisma.hbs
- templates/create/next/prisma/schema.prisma.hbs
- src/index.ts
- templates/create/tanstack-start/prisma/seed.ts.hbs
- templates/create/nuxt/prisma/seed.ts.hbs
- templates/create/nest/prisma/schema.prisma.hbs
- templates/create/nest/src/users.service.ts.hbs
- templates/create/astro/prisma/seed.ts.hbs
- templates/create/elysia/prisma/schema.prisma.hbs
- templates/create/nuxt/prisma/schema.prisma.hbs
- templates/create/turborepo/packages/db/prisma/schema.prisma.hbs
- templates/create/elysia/prisma/seed.ts.hbs
Always scaffold the Composer graph, dependencies, build artifacts, and deploy scripts for every template. Remove Deno support instead of maintaining a separate non-Composer runtime path. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/commands/create.ts (1)
443-531: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winRestore a deploy next step after cancellation.
Line 445 disables local Prisma Postgres setup before Composer deployment succeeds. If
executeComposerDeployContextreturnscancelled, Lines 483-490 continue without addingdeploytoprismaResult.nextSteps. The generated project then has no provisioned database and no migration or seed execution path in the completion output.Add a cancellation branch that reports the cancellation and adds the package-manager-specific
deploycommand. For Composer Postgres projects, that command provisions the database and runscomposer:database:setup.Proposed fix
if (!result.ok && !result.cancelled) { return { ok: false, stage: "composer_deploy", error: result.error, }; } + if (result.cancelled) { + prismaResult.warningSection += "\n\n- Composer deployment was cancelled."; + prismaResult.nextSteps.push( + `- ${getRunScriptCommand(context.prismaSetupContext.packageManager, "deploy")}`, + ); + } if (result.ok) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/commands/create.ts` around lines 443 - 531, In the composer deployment flow around executeComposerDeployContext, handle result.cancelled before continuing: report the cancellation and append the package-manager-specific deploy command to prismaResult.nextSteps. Preserve the existing successful deployment behavior, and ensure Composer Postgres projects use the deploy command that provisions the database and runs composer:database:setup.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/commands/create.ts`:
- Around line 443-531: In the composer deployment flow around
executeComposerDeployContext, handle result.cancelled before continuing: report
the cancellation and append the package-manager-specific deploy command to
prismaResult.nextSteps. Preserve the existing successful deployment behavior,
and ensure Composer Postgres projects use the deploy command that provisions the
database and runs composer:database:setup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: b6b580d5-b256-4ce0-8bfb-a5b2929af0c9
📒 Files selected for processing (99)
README.mdsrc/commands/create.tssrc/constants/dependencies.tssrc/tasks/deploy-with-composer.tssrc/tasks/install.tssrc/tasks/setup-prisma.tssrc/templates/render-create-template.tssrc/templates/shared.tssrc/types.tssrc/utils/package-manager.tssrc/utils/runtime.tstemplates/create/astro/README.md.hbstemplates/create/astro/deno.json.hbstemplates/create/astro/module.ts.hbstemplates/create/astro/prisma-composer.config.ts.hbstemplates/create/astro/prisma/schema.prisma.hbstemplates/create/astro/prisma/seed.ts.hbstemplates/create/astro/service.ts.hbstemplates/create/astro/src/lib/prisma.ts.hbstemplates/create/elysia/README.md.hbstemplates/create/elysia/deno.json.hbstemplates/create/elysia/module.ts.hbstemplates/create/elysia/package.json.hbstemplates/create/elysia/prisma-composer.config.ts.hbstemplates/create/elysia/prisma/schema.prisma.hbstemplates/create/elysia/prisma/seed.ts.hbstemplates/create/elysia/service.ts.hbstemplates/create/elysia/src/index.ts.hbstemplates/create/elysia/src/lib/prisma.ts.hbstemplates/create/hono/README.md.hbstemplates/create/hono/deno.json.hbstemplates/create/hono/module.ts.hbstemplates/create/hono/package.json.hbstemplates/create/hono/prisma-composer.config.ts.hbstemplates/create/hono/prisma/schema.prisma.hbstemplates/create/hono/prisma/seed.ts.hbstemplates/create/hono/service.ts.hbstemplates/create/hono/src/index.ts.hbstemplates/create/hono/src/lib/prisma.ts.hbstemplates/create/nest/README.md.hbstemplates/create/nest/deno.json.hbstemplates/create/nest/module.ts.hbstemplates/create/nest/package.json.hbstemplates/create/nest/prisma-composer.config.ts.hbstemplates/create/nest/prisma/schema.prisma.hbstemplates/create/nest/prisma/seed.ts.hbstemplates/create/nest/src/app.module.ts.hbstemplates/create/nest/src/lib/prisma.ts.hbstemplates/create/nest/src/main.ts.hbstemplates/create/nest/src/prisma.service.ts.hbstemplates/create/nest/src/service.ts.hbstemplates/create/nest/src/users.controller.ts.hbstemplates/create/nest/src/users.service.ts.hbstemplates/create/next/README.md.hbstemplates/create/next/deno.json.hbstemplates/create/next/module.ts.hbstemplates/create/next/prisma-composer.config.ts.hbstemplates/create/next/prisma/schema.prisma.hbstemplates/create/next/prisma/seed.ts.hbstemplates/create/next/service.ts.hbstemplates/create/next/src/lib/prisma.ts.hbstemplates/create/nuxt/README.md.hbstemplates/create/nuxt/deno.json.hbstemplates/create/nuxt/module.ts.hbstemplates/create/nuxt/prisma-composer.config.ts.hbstemplates/create/nuxt/prisma/schema.prisma.hbstemplates/create/nuxt/prisma/seed.ts.hbstemplates/create/nuxt/server/utils/prisma.ts.hbstemplates/create/nuxt/service.ts.hbstemplates/create/svelte/README.md.hbstemplates/create/svelte/deno.json.hbstemplates/create/svelte/module.ts.hbstemplates/create/svelte/package.json.hbstemplates/create/svelte/prisma-composer.config.ts.hbstemplates/create/svelte/prisma/schema.prisma.hbstemplates/create/svelte/prisma/seed.ts.hbstemplates/create/svelte/service.ts.hbstemplates/create/svelte/src/lib/server/prisma.ts.hbstemplates/create/svelte/svelte.config.js.hbstemplates/create/tanstack-start/README.md.hbstemplates/create/tanstack-start/deno.json.hbstemplates/create/tanstack-start/module.ts.hbstemplates/create/tanstack-start/prisma-composer.config.ts.hbstemplates/create/tanstack-start/prisma/schema.prisma.hbstemplates/create/tanstack-start/prisma/seed.ts.hbstemplates/create/tanstack-start/service.ts.hbstemplates/create/tanstack-start/src/lib/prisma.server.ts.hbstemplates/create/turborepo/README.md.hbstemplates/create/turborepo/apps/api/package.json.hbstemplates/create/turborepo/apps/api/src/index.ts.hbstemplates/create/turborepo/apps/api/src/service.ts.hbstemplates/create/turborepo/deno.json.hbstemplates/create/turborepo/module.ts.hbstemplates/create/turborepo/package.json.hbstemplates/create/turborepo/packages/db/package.json.hbstemplates/create/turborepo/packages/db/prisma/schema.prisma.hbstemplates/create/turborepo/packages/db/prisma/seed.ts.hbstemplates/create/turborepo/packages/db/src/client.ts.hbstemplates/create/turborepo/prisma-composer.config.ts.hbs
💤 Files with no reviewable changes (58)
- templates/create/turborepo/package.json.hbs
- templates/create/tanstack-start/deno.json.hbs
- templates/create/astro/deno.json.hbs
- templates/create/elysia/deno.json.hbs
- templates/create/turborepo/packages/db/package.json.hbs
- templates/create/hono/service.ts.hbs
- templates/create/next/deno.json.hbs
- templates/create/turborepo/deno.json.hbs
- templates/create/hono/deno.json.hbs
- templates/create/nuxt/deno.json.hbs
- templates/create/nest/deno.json.hbs
- templates/create/nuxt/README.md.hbs
- templates/create/turborepo/prisma-composer.config.ts.hbs
- templates/create/hono/README.md.hbs
- templates/create/elysia/prisma-composer.config.ts.hbs
- templates/create/elysia/module.ts.hbs
- templates/create/next/README.md.hbs
- templates/create/elysia/service.ts.hbs
- templates/create/turborepo/packages/db/prisma/schema.prisma.hbs
- templates/create/next/module.ts.hbs
- templates/create/nuxt/prisma-composer.config.ts.hbs
- templates/create/svelte/svelte.config.js.hbs
- templates/create/tanstack-start/prisma/schema.prisma.hbs
- templates/create/turborepo/README.md.hbs
- templates/create/nest/prisma-composer.config.ts.hbs
- templates/create/nest/README.md.hbs
- templates/create/astro/prisma-composer.config.ts.hbs
- templates/create/hono/prisma/schema.prisma.hbs
- templates/create/turborepo/apps/api/src/service.ts.hbs
- templates/create/astro/prisma/schema.prisma.hbs
- templates/create/nuxt/service.ts.hbs
- templates/create/svelte/service.ts.hbs
- templates/create/svelte/prisma-composer.config.ts.hbs
- templates/create/nuxt/prisma/schema.prisma.hbs
- templates/create/next/service.ts.hbs
- templates/create/turborepo/module.ts.hbs
- templates/create/elysia/prisma/schema.prisma.hbs
- templates/create/tanstack-start/service.ts.hbs
- templates/create/next/prisma-composer.config.ts.hbs
- templates/create/nest/src/service.ts.hbs
- templates/create/nuxt/module.ts.hbs
- templates/create/hono/prisma-composer.config.ts.hbs
- templates/create/elysia/README.md.hbs
- templates/create/nest/prisma/schema.prisma.hbs
- templates/create/svelte/README.md.hbs
- templates/create/astro/README.md.hbs
- templates/create/hono/module.ts.hbs
- templates/create/astro/module.ts.hbs
- templates/create/tanstack-start/README.md.hbs
- templates/create/tanstack-start/prisma-composer.config.ts.hbs
- templates/create/next/prisma/schema.prisma.hbs
- templates/create/tanstack-start/module.ts.hbs
- templates/create/svelte/module.ts.hbs
- src/tasks/setup-prisma.ts
- templates/create/astro/service.ts.hbs
- templates/create/svelte/deno.json.hbs
- templates/create/svelte/prisma/schema.prisma.hbs
- templates/create/nest/module.ts.hbs
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@templates/create/nest/package.json.hbs`:
- Line 10: Update the build script’s esbuild arguments to use JSON-escaped
double quotes for both NestJS wildcard patterns, replacing the literal
single-quoted --external values. Preserve the existing patterns and other build
options, and validate the generated script on Windows.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 36360dbe-62c6-4c5e-95ed-b1a712e4147e
📒 Files selected for processing (7)
src/constants/dependencies.tstemplates/create/elysia/src/index.ts.hbstemplates/create/nest/package.json.hbstemplates/create/svelte/README.md.hbstemplates/create/svelte/package.json.hbstemplates/create/svelte/service.ts.hbstemplates/create/svelte/vite.config.ts
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Remove the create-db and database URL CLI paths so PostgreSQL is always managed by the generated Composer graph. Generate an initial migration locally, run migrate deploy and seed as part of deployment, and cover every template and package manager with automated tests. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Use the selected runtime for Bun, support package-manager command shims on Windows, redact database URLs, and always clean up temporary connections. Also normalize empty pnpm override maps and cover the behavior with tests. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Give page-based templates one minimal shared visual system and keep API-only templates consistent with a small root status response. Validate every generated framework build and cover the shared output in the template matrix. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Clarify scaffold state versus immediate deployment and stop recommending the Compute-specific skill for Composer deployments. Expand regression coverage for generated dependencies and pnpm override merging. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Member
Author
Review-comment auditRechecked all 19 inline threads plus the outside-diff cancellation finding against the current branch. Changes made in
Verified without further code changes:
The old post-deploy URL-resolution finding no longer maps to the current architecture: immediate deployment intentionally executes build, Composer deployment, migration, and seed as one requested operation. A migration or seed failure therefore remains an overall deploy failure instead of being reported as success. Validation: |
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Route Composer deployment and Postgres setup through @prisma/cli@next so stored browser sessions and service tokens use the official authentication path. Open browser login for an interactive missing session, fail headless runs with exact recovery commands, adopt the postgres command namespace and structured result envelope, and remove the private deployment-result side channel. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
Hide successful immediate-deploy output behind a spinner while preserving full output with --verbose. Recognize the Platform API con_ connection id shape so temporary migration connections are removed. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Implementation PR — do not merge yet
This PR is ready for review, but it must not be merged or released yet. The confirmed incompatibility is Next.js deployed with pnpm's default isolated layout: its standalone artifact contains pnpm symlinks that the current Composer archive pipeline does not reliably preserve, including targets longer than the USTAR 100-byte linkname field.
The closed
prisma/composer#219is not a dependency. We are intentionally not carrying its duplicate Compute provider/archive implementation forward. Before merge, update the generated@prisma/composerpackage pins to the first release containing the Alchemy migration and rerun the deployment matrix.Resulting create-prisma DX
Deploy to Prisma now?prisma migrate deploy, and seeds automatically.pnpm run deploy.Summary
prisma.compute.tswith Composer deploymentcreate-dbprovisioning path and temporary claim database flow--database-url; PostgreSQL is always Composer-managed, while other providers readDATABASE_URLfrom the environmentdeployscript for immediate deployment so migration and seed are part of the same user-visible operationprisma migrate deployin cloud deployment; never runprisma migrate devagainst the deployed database.envDATABASE_URLis missing@prisma/cli@next, which renders the structured deployment summary directly--verbosestreams the complete build, Composer, migration, and seed outputcon_…connection-id shapepnpm exec prismaandbunx --bun prisma, never./node_modules/.bin/prismaAuthentication through the consolidated CLI
Deployment now runs through the package-manager-native
@prisma/cli@next composer deploycommand. create-prisma reuses the active stored OAuth workspace orPRISMA_SERVICE_TOKEN, opensauth loginwhen an interactive user is signed out, and gives headless runs exact login/deploy-later guidance. It never reads credential files or handles token values itself.Live Bun deployment verification
On 2026-08-13, the exact preview flow from
bunx create-prisma@pr52was tested with TanStack Start, PostgreSQL, Bun, dependency installation, and immediate deployment. Browser authentication completed successfully through the consolidated CLI. The unmodified preview then stopped before Composer atCLI.CONFIG_UNREADABLE:composer deployevaluated the stable ORMprisma.config.ts, whose strictenv("DATABASE_URL")cannot succeed before Composer provisions Prisma Postgres.A diagnostic-only rerun removed that file from unified-CLI discovery and aligned the app-side Composer packages with the
0.6.0-dev.16version embedded by@prisma/cli@next. That deployed successfully through Bun, provisioned Prisma Postgres, applied the initial migration, seeded Alice and Bob, and returned HTTP 200 from https://o8ocmg8tllnxck3nvifvtpna.ewr.prisma.build. The first rerun also exposed theconn_vs realcon_connection-id bug; after the parser fix, a second live migration/seed run removed its temporary connection and left nocreate-prisma-deploy-*connection.Neither diagnostic bypass is generated or included in this PR. The config coexistence and Composer-version alignment must be fixed in their owning packages before merge.
Confirmed Composer compatibility issue
Next.js + pnpm is the reproduced failure; this PR does not claim that every framework/package-manager combination is broken. The defect is in artifact assembly/archiving rather than Next.js itself, so another combination could also be affected when its deploy artifact retains similar symlinks. No equivalent failure has been confirmed for SvelteKit, Nuxt, Astro, TanStack Start, Hono, Elysia, or NestJS. The full cloud deployment matrix remains a required verification after the fixed Composer release.
No package-manager workarounds
This change does not generate a hoisted linker configuration, dereference dependency symlinks, copy
node_modules, or add a SvelteKit post-build bundle. Next.js + pnpm must deploy from its native output; the fix belongs in the Composer/Alchemy artifact pipeline.Validation
built CLI exits before command parsing on Node.js 22.14.0 and runs normally on Node.js 24.19.0
bun run checkbun run typecheckbun run test— 98 passing tests and 1,381 assertionsbun run buildverified published
@prisma/cli@next(8.0.0-rc.1) through npm, pnpm, Yarn, and Bun package runnersverified signed-out browser/headless auth behavior and the generated Postgres setup error envelope against the published CLI
automated 72-variant render matrix: 9 templates × 4 package managers × Prisma Postgres/external database
audited all 19 inline review threads plus the outside-diff cancellation finding against the current branch
package-manager command tests for npm, pnpm, Yarn, and Bun
generated, installed, generated Prisma artifacts for, and production-built all nine Bun + SQLite starters: Next.js, SvelteKit, Astro, Nuxt, TanStack Start, Hono, Elysia, NestJS, and Turborepo
visually verified the seeded starter UI at 1280px desktop and 390px mobile with no console errors or horizontal overflow
verified all five generated page starters receive the byte-identical shared stylesheet
installed real Hono + Bun + PostgreSQL scaffold successfully generated Prisma Client and
prisma/migrations/00000000000000_init/migration.sqlverified the PostgreSQL scaffold writes no
.envfileverified explicit external-database deployment without
DATABASE_URLexits before creating a projectverified CLI help exposes no
--database-url, schema preset, generate, migrate, seed, or Prisma Postgres optionBefore merge
@prisma/cli composer deploycoexist with the stable ORMprisma.config.tsused by these templates; it must not evaluate and reject that file before Composer can provision the database.@prisma/cli@nextcurrently embeds Composer0.6.0-dev.16while generated apps use0.6.0.