[#94] feat(guestbook): 방명록 및 댓글 작성 기능 구현 - #98
Merged
Conversation
- 방명록 엔트리에 댓글을 작성할 수 있는 기능 추가 - CommentWriteBox에 entryId 및 onSubmit props 전달하도록 수정 - insertReply API 구현 및 GuestBook에 댓글 작성 로직 구현 - searchFriends에서 userId가 undefined일 때 빈 배열 반환하도록 수정
github-actions
Bot
requested review from
RumPumpumpum,
stupilman and
suyeon1104
November 18, 2025 05:25
There was a problem hiding this comment.
Pull Request Overview
This PR implements guestbook entry and comment writing functionality, allowing users to create new guestbook entries and reply to existing ones. The changes convert the write components to controlled components with proper state management and integrate them with Supabase API calls.
- Implemented
insertEntryandinsertReplyAPI functions for creating guestbook entries and comments - Converted
GuestbookWriteBoxandCommentWriteBoxto controlled components withonSubmitcallbacks - Fixed
searchFriendsto return an empty array instead ofundefinedwhenuserIdis not provided - Corrected error logging to output actual error objects instead of the string "error"
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/friends/api/searchFriends.ts | Changed return value from undefined to empty array when userId is not provided |
| src/components/minihome/guestbook/api/guestbook.ts | Added insertReply and insertEntry API functions; updated return type of getGuestBookWithComment for consistency |
| src/components/minihome/guestbook/GuestbookWriteBox.tsx | Converted to controlled component with state management and onSubmit callback |
| src/components/minihome/guestbook/GuestBook.tsx | Integrated write handlers for entries and replies; fixed error logging |
| src/components/minihome/guestbook/CommentWriteBox.tsx | Converted to controlled component with state management and onSubmit callback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- 새로운 방명록 엔트리 작성 기능 구현 - insertEntry API 추가 및 GuestBook 컴포넌트에 엔트리 생성 로직 연동 - GuestbookWriteBox를 제어 컴포넌트로 수정하고 onSubmit 콜백 지원 추가
sageherb
force-pushed
the
feature/guestbook-write
branch
from
November 18, 2025 05:31
95a8b1b to
30d16fe
Compare
stupilman
approved these changes
Nov 18, 2025
RumPumpumpum
approved these changes
Nov 18, 2025
RumPumpumpum
left a comment
RumPumpumpum
left a comment
Collaborator
There was a problem hiding this comment.
구현 확인했습니다.
고생하셨습니다~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 개요
방명록 및 댓글 작성 기능 구현
✅ 관련 이슈
🛠️ 상세 작업 내용
📸 스크린샷
N/A
N/A
👥 리뷰 확인 사항
N/A